621465 - "Restart now" doorhanger after extension install is now button-within-a-button

Status: VERIFIED DUPLICATE of bug 577930

(Firefox :: General, defect)

Description

[Daniel Holbert [:dholbert]]

STEPS TO REPRODUCE:
 1. Install an extension
     e.g. https://addons.mozilla.org/en-US/firefox/addon/15003/
 2. Inspect the restart doorhanger that appears.

Starting with today's nightly, the "restart now" button is a button-within-a-button. Yesterday (and in all earlier nightlies that I've seen in recent history) it was much cleaner looking. See upcoming screenshots.

Regression range:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=0ab0603bea99&tochange=f5eb60e1bc6e

I'm guessing this is from http://hg.mozilla.org/mozilla-central/rev/44382cb1ecc6
which backed out http://hg.mozilla.org/mozilla-central/rev/1a15dd47da63
which tweaked some button styling.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screenshot: 2010-12-25 nightly (fine)

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: screenshot: 2010-12-26 nightly (button-within-a-button)

Comment 3

[Daniel Holbert [:dholbert]]

Alternate/Simpler steps to reproduce:
 1. Visit https://wiki.mozilla.org/index.php?title=Special:UserLogin
 2. Type gibberish for username & password, and click "Login"
 3. Inspect "Remember Password" button on the doorhanger that appears.

Comment 4

[Dão Gottwald [:dao]]

bug 577930 and bug 621395 track solutions for this