577930 - Linux styling of menu buttons in popup notifications

Status: RESOLVED WORKSFORME

(Toolkit :: Themes, enhancement)

Description

[Peter Henkel [:Terepin]]

User-Agent:       Mozilla/5.0 (Windows; Windows NT 6.1; WOW64; sk; rv:2.0b2pre) Gecko/20100710 Minefield/4.0b2pre
Build Identifier: Mozilla/5.0 (Windows; Windows NT 6.1; WOW64; sk; rv:2.0b2pre) Gecko/20100710 Minefield/4.0b2pre

Doorhanger is using grey pop-up with squareish buttons.

Reproducible: Always

Comment 1

[:Margaret Leibovic]

Attachment: wip

Using -moz-appearance: menulist; on the button makes it fit in with the current theme. However, to avoid showing two dropmarkers, I need to hide the dropmarker that the split button adds, which is kind of sketchy. Clicking on different parts of the button seems to work as expected, but this doesn't seem like the correct approach.

Comment 2

[:Margaret Leibovic]

Attachment: wip screenshot

This doesn't match the mockup, but the mockup doesn't match the rest of the current theme, like the menulist buttons in the edit bookmark panel, so maybe there should be another bug to universally update these buttons to avoid inconsistencies.

Comment 4

[:Margaret Leibovic]

Attachment: wip v2

This patch still needs the correct background coloring, but it has the correct active states for the left/right sides of the button.

Comment 5

[:Margaret Leibovic]

Attachment: wip v2

Whoops, I uploaded the wrong version of the patch.

Comment 6

[:Margaret Leibovic]

Bug 604257 and bug 408284 make it sound like the arrows are a challenge. Stephen, should we make a contingency plan in case we can't get arrow panels to work on linux? Is there anything we can do to make the rectangular panels better?

Comment 7

[Johnathan Nightingale [:johnath]]

shorlander - are the changes here blocking?

Comment 8

[Stephen Horlander [:shorlander]]

(In reply to comment #7)
> shorlander - are the changes here blocking?

They should block, but I am not sure how this bug differs from bug 604257 (which is blocking final+).

Comment 9

[Dão Gottwald [:dao]]

The diversity of Gtk themes makes this potentially delicate; I don't think we can block on it. We need to test the patch with a range of setups and take it if it works and leave it if it doesn't.

Comment 10

[Dietrich Ayala (:dietrich)]

Can't make a blocking call until the question in comment #8 is answered.

Comment 11

[:Margaret Leibovic]

I'm updating the bug summary to make this bug about the button styling for the doorhanger notifications, so this bug is the linux version of bug 577928. The patch for this bug should just involve adding those button style rules to gnomestripe/global/notification.css.

Bug 604257 is about general arrow panel stying, which should add the arrows and general panel styling to gnomestripe/global/popup.css.

I think it's best to keep these bugs separate, for the sake of easier reviewing.

Comment 13

[Dão Gottwald [:dao]]

bug 621395 improved the default styling for these buttons on Linux, so this probably doesn't need to block anymore.

Comment 14

[Daniel Holbert [:dholbert]]

These buttons *just* became weirder-looking than they've been in a long time, though, as described in bug 621465...  You duped that to this bug, but perhaps that regression should block?

Comment 15

[Daniel Holbert [:dholbert]]

Ah, my bad -- looks like bug 621395 (which Dão mentioned in comment 13) landed this morning, so its effects won't show up in nightlies until tomorrow, which is why I thought bug 621465 was still an issue.

I just tried an updated-to-now mozilla-central local build and confirmed that the buttons look much nicer now.  Thanks Dao!

Comment 16

[Matthew N. [:MattN]]

Doorhangers have been restyled many times since this was filed.