621649 - bookmark all pages in panorama view should respect key focus

Status: RESOLVED WONTFIX

(Firefox Graveyard :: Panorama, defect, P3)

Description

[timeless]

these steps apply to OS X where the menubar from the browser is still visible in panorama view and where the keystrokes from those menu items still work. I'm not testing on other platforms.

steps:
1. create 3 tab groups with 2, 3 and 4 tabs respectively
2. switch to panorama
3. click a tab from the group of 2 to exit panorama with that tab/group of two active
4. click the panorama button
5. use the <up> or <down> arrow keys until you select a tab from some other group (3 or 4)
6. use bookmarks>Bookmark All Tabs (cmd-shift-d) to create a tab group
7. call it "3 tabs" or "4 tabs" based on the group where your focus is painted
8. open bookmarks>show all bookmarks
9. examine the tabs in "3 tabs" or "4 tabs"

expected results:
3 or 4 bookmarks based on whatever was focused at step 5

actual results:
2 bookmarks from step 3

Build identifier: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b9pre) Gecko/20101227 Firefox/4.0b9pre

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to comment #0)
> these steps apply to OS X where the menubar from the browser is still visible
> in panorama view and where the keystrokes from those menu items still work. I'm
> not testing on other platforms.

As far as I can see, those steps all do the same thing on Win7 for me (other than the using the menubar, so I'm just using Ctrl-Shift-D to bookmark all tabs).

Whatever was the most recently 'active' group (active == whatever was showing last in not-panorama mode) is what gets bookmarked, regardless of what has keyboard focus in panorama mode.

Comment 2

[Kevin Hanes]

Seems like a good case to support.

Comment 3

[Justin Dolske [:Dolske]]

Panorama has been removed from Firefox 45, currently in Beta and scheduled for release on March 7th. As such, I'm closing all existing Panorama bugs.

If you are still using Panorama, you will see a deprecation message in Firefox 44, and when 45 is released your tab group data will be migrated to bookmarks, with a folder for each group. There are also a few addons offering similar functionality.

See https://support.mozilla.org/en-US/kb/tab-groups-removal for more info.

We're removing Panorama because it has extremely low usage (about 0.01% of users), and has a large number of bugs and usability issues. The cost of fixing all those issues is far too high to justify, and so we'll instead be focusing our time and energy on improving other parts of Firefox.