622191 - [backend] Build the review page

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P1)

Description

[Wil Clouser [:clouserw]]

Behold the review page!

https://addons.allizom.org/en-US/editors/review/121634?num=47

The backend of this involves showing stuff on the page (relatively simple) and accepting POST stuff (more complicated).  I'm not going to list everything here that is done on POST, but please look through Remora's controllers/editors_controller.php (and the more interesting stuff in controllers/components/editors.php).  

Other stuff worth noting:

- The prev/next link in the top right only shows up if num is in the URL
- The most complex part of this is the grey box in the middle.  Note little things like the "notify me" box defaults to yes for rejections.
- This bug does NOT include the "Editor Comments" section

Comment 1

[Andy McKay]

nominationmessage is shown on the remora page, but isn't mentioned in the zamboni model, so assuming this is no longer used and won't be shown.

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

(In reply to comment #1)
> nominationmessage is shown on the remora page, but isn't mentioned in the
> zamboni model, so assuming this is no longer used and won't be shown.

We need it.

Comment 3

[Andy McKay]

But I don't think its set at all anywhere in zamboni. Is it missing from other step of the addon submission process?

Comment 4

[Jorge Villalobos [:jorgev] (he/him)]

We used to require a nomination message with information about the add-on (how it works, how to test, etc.). For a while we've had the Notes to Reviewer, which are optionally included on every version of the add-on and can serve the same purpose.

While I'm OK with not requiring the nomination message in the new system, there's a lot of useful historical data in the nomination messages of all existing add-ons. So, we should still display it in the new review pages.

Comment 5

[Andy McKay]

We haven't got a model for editor_subscriptions yet?

Comment 6

[Wil Clouser [:clouserw]]

(In reply to comment #5)
> We haven't got a model for editor_subscriptions yet?

That looks like the case

Comment 7

[Andy McKay]

https://github.com/jbalogh/zamboni/commit/c26b211a5a5a0927b2383a3aab0fe068393620ef