622238 - In tests: JavaScript Warning: "assignment to undeclared variable item" {file: "chrome://browser/content/tabview.js" line: 7374}

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect, P5)

Description

[Michael Yoshitaka Erlewine [:mitcho]]

JavaScript Warning: "assignment to undeclared variable item" {file: "chrome://browser/content/tabview.js" line: 7374}

This corresponds to the line

>     for each(item in TabItems.getItems()) {

in UI_getClosestTab.

Comment 1

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Trivial patch

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 500479 [details] [diff] [review]
Trivial patch

Don't use 'for each' for arrays. See the note on https://developer.mozilla.org/en/JavaScript/Reference/Statements/for...in#Description for details.

Comment 3

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Trivial patch, round 2

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 500531 [details] [diff] [review]
Trivial patch, round 2

a=beltzner

Comment 5

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Patch for checkin

Comment 6

[Ian Gilman [:iangilman]]

http://hg.mozilla.org/mozilla-central/rev/ff1749422d41