Write tests for input context menus

RESOLVED FIXED in Firefox 26

Status

()

Firefox
Menus
RESOLVED FIXED
7 years ago
4 years ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

Trunk
Firefox 26
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

7 years ago
Created attachment 500533 [details] [diff] [review]
Tests

Because of bug 622283, I have to write context menu checks for input element in a separate file. This will include tests for bug 558651.

I'm assuming this file might be random on linux as the other context menu check. I should probably give it a try.
Attachment #500533 - Flags: review?(gavin.sharp)
(Assignee)

Updated

7 years ago
Attachment #500533 - Flags: review?(sdwilsh)
Comment on attachment 500533 [details] [diff] [review]
Tests

It looks like test_contextmenu_input.html should be copied from test_contextmenu.html, and like they should share the common code (just throw it in a test_contextmenu_common.js file or something). The "Test for Login Manager" comment in both of them should probably be updated too.

It's kind of annoying to do this work to split them out when we could fix bug 622283 instead, though. Is that so hard to do that we need to do this in the interim?
Attachment #500533 - Flags: review?(sdwilsh)
Attachment #500533 - Flags: review?(gavin.sharp)
Attachment #500533 - Flags: review-
(Assignee)

Comment 2

4 years ago
Created attachment 789574 [details] [diff] [review]
Tests

This new patch applies the comments from the previous comment.
I will enable/disable the test on platforms depending on try results (it will likely be disabled on GTK even if it is working locally).
Attachment #500533 - Attachment is obsolete: true
Attachment #789574 - Flags: review?(netzen)
(Assignee)

Comment 3

4 years ago
Created attachment 789604 [details] [diff] [review]
Tests
Attachment #789574 - Attachment is obsolete: true
Attachment #789574 - Flags: review?(netzen)
Attachment #789604 - Flags: review?(netzen)
Comment on attachment 789604 [details] [diff] [review]
Tests

Review of attachment 789604 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch, you can r=me with testNum 13's input.type error

::: browser/base/content/test/test_contextmenu_input.html
@@ +2,5 @@
> +<html>
> +<head>
> +  <title>Tests for browser context menu</title>
> +  <script type="text/javascript" src="/MochiKit/packed.js"></script>
> +  <script type="text/javascript" src="/tests/SimpleTest/SimpleTest.js"></script>  

nit: trailing whitespace

@@ +206,5 @@
> +          input.type = 'time';
> +        } else if (testNum == 12) {
> +          input.type = 'number';
> +        } else if (testNum == 13) {
> +          input.type = 'number';

input.type = 'color';
Attachment #789604 - Flags: review?(netzen)
(Assignee)

Comment 5

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/24b9290db3a4
Flags: in-testsuite+
Target Milestone: --- → Firefox 26

Updated

4 years ago
Blocks: 905176
https://hg.mozilla.org/mozilla-central/rev/24b9290db3a4
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.