Closed Bug 622284 Opened 11 years ago Closed 9 years ago

Write tests for input context menus

Categories

(Firefox :: Menus, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 26

People

(Reporter: mounir, Assigned: mounir)

References

Details

Attachments

(1 file, 2 obsolete files)

Attached patch Tests (obsolete) — Splinter Review
Because of bug 622283, I have to write context menu checks for input element in a separate file. This will include tests for bug 558651.

I'm assuming this file might be random on linux as the other context menu check. I should probably give it a try.
Attachment #500533 - Flags: review?(gavin.sharp)
Attachment #500533 - Flags: review?(sdwilsh)
Comment on attachment 500533 [details] [diff] [review]
Tests

It looks like test_contextmenu_input.html should be copied from test_contextmenu.html, and like they should share the common code (just throw it in a test_contextmenu_common.js file or something). The "Test for Login Manager" comment in both of them should probably be updated too.

It's kind of annoying to do this work to split them out when we could fix bug 622283 instead, though. Is that so hard to do that we need to do this in the interim?
Attachment #500533 - Flags: review?(sdwilsh)
Attachment #500533 - Flags: review?(gavin.sharp)
Attachment #500533 - Flags: review-
Attached patch Tests (obsolete) — Splinter Review
This new patch applies the comments from the previous comment.
I will enable/disable the test on platforms depending on try results (it will likely be disabled on GTK even if it is working locally).
Attachment #500533 - Attachment is obsolete: true
Attachment #789574 - Flags: review?(netzen)
Attached patch TestsSplinter Review
Attachment #789574 - Attachment is obsolete: true
Attachment #789574 - Flags: review?(netzen)
Attachment #789604 - Flags: review?(netzen)
Comment on attachment 789604 [details] [diff] [review]
Tests

Review of attachment 789604 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch, you can r=me with testNum 13's input.type error

::: browser/base/content/test/test_contextmenu_input.html
@@ +2,5 @@
> +<html>
> +<head>
> +  <title>Tests for browser context menu</title>
> +  <script type="text/javascript" src="/MochiKit/packed.js"></script>
> +  <script type="text/javascript" src="/tests/SimpleTest/SimpleTest.js"></script>  

nit: trailing whitespace

@@ +206,5 @@
> +          input.type = 'time';
> +        } else if (testNum == 12) {
> +          input.type = 'number';
> +        } else if (testNum == 13) {
> +          input.type = 'number';

input.type = 'color';
Attachment #789604 - Flags: review?(netzen)
https://hg.mozilla.org/integration/mozilla-inbound/rev/24b9290db3a4
Flags: in-testsuite+
Target Milestone: --- → Firefox 26
Blocks: 905176
https://hg.mozilla.org/mozilla-central/rev/24b9290db3a4
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.