Closed Bug 905176 Opened 8 years ago Closed 8 years ago

For input/textarea/contenteditable with spellcheck="false", "Check Spelling" context menu should be disabled/hidden

Categories

(Firefox :: Menus, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 26
Tracking Status
firefox23 --- unaffected
firefox24 + verified
firefox25 + verified
firefox26 + verified

People

(Reporter: alice0775, Assigned: ehsan.akhgari)

References

(Depends on 2 open bugs)

Details

Attachments

(2 files)

Attached file spellcheck.html
Steps To Reproduce:
1. Open attached
2. Right click on these editable element

3. Try to turn on "Check Spelling" context menu 

Actual Results:
"Check Spelling" is enabled state
"Check Spelling" is able to toggle the state.

Expected Results:
"Check Spelling" should be disabled(gray color or hidden).
"Check Spelling" should be not able to toggle the state.
Component: General → Menus
Version: 24 Branch → Trunk
I think this is what we should do, yes!
See Also: → 904553
Attached patch Patch (v1)Splinter Review
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #790326 - Flags: review?(mconley)
Comment on attachment 790326 [details] [diff] [review]
Patch (v1)

Review of attachment 790326 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine to me by inspection. Thanks!
Attachment #790326 - Flags: review?(mconley) → review+
We need to track this instead of bug 904553.
Bug 622284 managed to completely bitrot my test changes :(
Depends on: 622284
https://hg.mozilla.org/mozilla-central/rev/af6e46ed8494
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
Ehsan, ready to uplift ?
Did the patch fix for element contenteditable only?
"Check Spelling" menu still appears on <input> and <textarea> with spellcheck="false".
(In reply to Alice0775 White from comment #9)
> Did the patch fix for element contenteditable only?
> "Check Spelling" menu still appears on <input> and <textarea> with
> spellcheck="false".

Yes, that's intentional, since we do support forcing spellchecking for them.
Comment on attachment 790326 [details] [diff] [review]
Patch (v1)

Trivial fix that we need to backport in order to have consistent UI (see bug 904553 for the context.)
Attachment #790326 - Flags: approval-mozilla-beta?
Attachment #790326 - Flags: approval-mozilla-aurora?
(In reply to :Ehsan Akhgari (needinfo? me!) from comment #10)
> (In reply to Alice0775 White from comment #9)
> > Did the patch fix for element contenteditable only?
> > "Check Spelling" menu still appears on <input> and <textarea> with
> > spellcheck="false".
> 
> Yes, that's intentional, since we do support forcing spellchecking for them.

Ok, I filed Bug 906979
Attachment #790326 - Flags: approval-mozilla-beta?
Attachment #790326 - Flags: approval-mozilla-beta+
Attachment #790326 - Flags: approval-mozilla-aurora?
Attachment #790326 - Flags: approval-mozilla-aurora+
Keywords: verifyme
There are some non-trivial merge conflicts with Aurora/Beta. Please create a branch-specific patch.
Flags: needinfo?(ehsan)
Verified as fixed on Firefox 24 beta 5 - 20130822154523 - on Windows 7, Mac OS X 10.7.5 and Ubuntu 13.04.
QA Contact: ioana.budnar
Verified as fixed on:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20100101 Firefox/25.0 (20130908004001)

Spell checking can be forced for input and textarea, but not for contenteditable.

The "Add dictionaries..." option displayed in the contenteditable contextual menu is very confusing, considering that the spell checking option is gone. Has it been left there by design? Could it be removed with the "Spell Check" option?
Flags: needinfo?(ehsan)
Verified as fixed on 
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 (20130909030204)
Status: RESOLVED → VERIFIED
Keywords: verifyme
(In reply to Ioana Budnar, QA [:ioana] from comment #16)
> Verified as fixed on:
> Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20100101 Firefox/25.0
> (20130908004001)
> 
> Spell checking can be forced for input and textarea, but not for
> contenteditable.
> 
> The "Add dictionaries..." option displayed in the contenteditable contextual
> menu is very confusing, considering that the spell checking option is gone.
> Has it been left there by design? Could it be removed with the "Spell Check"
> option?

There's no design behind any of this, not at least a recent one.  Please feel free to file a bug on that, but I probably won't have enough time to work on it myself.  Sorry!
Flags: needinfo?(ehsan)
(In reply to :Ehsan Akhgari (needinfo? me!) from comment #18)
> There's no design behind any of this, not at least a recent one.  Please
> feel free to file a bug on that, but I probably won't have enough time to
> work on it myself.  Sorry!

Thanks for the info. I filed bug 915117.
Why must the web browser comply to a website request to turn off the ability to use Firefox built in spell checker? 

Why should a website force us to use their WYSIWYG text editor's clunky spell checker? 

We know Firefox spell checker out-best them. Why take in-line as you type spell checking in multiple languages [dictionaries] away from your browser's end users? I don't understand why websites should be able mess with our browser settings and mess with our on-the-web text editing experience. It is our body of text and we should be able to spell check the heck out of it with Firefox's spell checker.

I don't see what was wrong with the previous behavior. Firefox built-in spell checker was off and the user had to turn it on [right click menu > spell check] it was not "On" Firefox was empowering its users by allowing them to still be able to use the built-in spell checker. Now we have been robbed of such empowering for-user yet harmless to-the-website setting

I see this as a big step backward, thus broken.
This is highly annoying, please restore the old behavior. What harm can it do to a webmaster if people can spellcheck their submissions to him?

Worst is if it's not even the webmaster's decision, but some software he had installed which had this nonsense in without anybody knowing (... not even the current developers of said software...)

See https://bugzilla.mozilla.org/show_bug.cgi?id=909352#c13 for one example.

Please, do the user's bidding, and don't lick up to big media, banks or whomever. Firefox, you are _our_ browser not theirs!
A good example of a case where a website would legitimately want to disable spell checking on a field is when they use it to display text which is not meant to be entered by the suer, and hence does not require to be spell checked.  A classic example is a textarea showing the EULA for a website.
(In reply to :Ehsan Akhgari (needinfo? me!) from comment #22)
> A good example of a case where a website would legitimately want to disable
> spell checking on a field is when they use it to display text which is not
> meant to be entered by the suer, and hence does not require to be spell
> checked.  A classic example is a textarea showing the EULA for a website.

Such fields should be read-only, so the readonly attribute might be a better indicator than spellcheck="false" that the user shouldn't be able to enable spell checking.
Depends on: 1350898
Depends on: 1671297
You need to log in before you can comment on or make changes to this bug.