905176 - For input/textarea/contenteditable with spellcheck="false", "Check Spelling" context menu should be disabled/hidden

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[Alice0775 White]

Attachment: spellcheck.html

Steps To Reproduce:
1. Open attached
2. Right click on these editable element

3. Try to turn on "Check Spelling" context menu 

Actual Results:
"Check Spelling" is enabled state
"Check Spelling" is able to toggle the state.

Expected Results:
"Check Spelling" should be disabled(gray color or hidden).
"Check Spelling" should be not able to toggle the state.

Comment 1

[(no longer active)]

I think this is what we should do, yes!

Comment 2

[(no longer active)]

Attachment: Patch (v1)

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 790326 [details] [diff] [review]
Patch (v1)

Review of attachment 790326 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine to me by inspection. Thanks!

Comment 4

[(no longer active)]

We need to track this instead of bug 904553.

Comment 5

[(no longer active)]

Bug 622284 managed to completely bitrot my test changes :(

Comment 6

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/af6e46ed8494

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/af6e46ed8494

Comment 8

[bhavana bajaj [:bajaj]]

Ehsan, ready to uplift ?

Comment 9

[Alice0775 White]

Did the patch fix for element contenteditable only?
"Check Spelling" menu still appears on <input> and <textarea> with spellcheck="false".

Comment 10

[(no longer active)]

(In reply to Alice0775 White from comment #9)
> Did the patch fix for element contenteditable only?
> "Check Spelling" menu still appears on <input> and <textarea> with
> spellcheck="false".

Yes, that's intentional, since we do support forcing spellchecking for them.

Comment 11

[(no longer active)]

Comment on attachment 790326 [details] [diff] [review]
Patch (v1)

Trivial fix that we need to backport in order to have consistent UI (see bug 904553 for the context.)

Comment 12

[Alice0775 White]

(In reply to :Ehsan Akhgari (needinfo? me!) from comment #10)
> (In reply to Alice0775 White from comment #9)
> > Did the patch fix for element contenteditable only?
> > "Check Spelling" menu still appears on <input> and <textarea> with
> > spellcheck="false".
> 
> Yes, that's intentional, since we do support forcing spellchecking for them.

Ok, I filed Bug 906979

Comment 13

[Ryan VanderMeulen [:RyanVM]]

There are some non-trivial merge conflicts with Aurora/Beta. Please create a branch-specific patch.

Comment 14

[(no longer active)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1a1ff090cd02
https://hg.mozilla.org/releases/mozilla-beta/rev/b8c61de105bf

Comment 15

[Ioana (away)]

Verified as fixed on Firefox 24 beta 5 - 20130822154523 - on Windows 7, Mac OS X 10.7.5 and Ubuntu 13.04.

Comment 16

[Ioana (away)]

Verified as fixed on:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20100101 Firefox/25.0 (20130908004001)

Spell checking can be forced for input and textarea, but not for contenteditable.

The "Add dictionaries..." option displayed in the contenteditable contextual menu is very confusing, considering that the spell checking option is gone. Has it been left there by design? Could it be removed with the "Spell Check" option?

Comment 17

[Ioana (away)]

Verified as fixed on 
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 (20130909030204)

Comment 18

[(no longer active)]

(In reply to Ioana Budnar, QA [:ioana] from comment #16)
> Verified as fixed on:
> Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20100101 Firefox/25.0
> (20130908004001)
> 
> Spell checking can be forced for input and textarea, but not for
> contenteditable.
> 
> The "Add dictionaries..." option displayed in the contenteditable contextual
> menu is very confusing, considering that the spell checking option is gone.
> Has it been left there by design? Could it be removed with the "Spell Check"
> option?

There's no design behind any of this, not at least a recent one.  Please feel free to file a bug on that, but I probably won't have enough time to work on it myself.  Sorry!

Comment 19

[Ioana (away)]

(In reply to :Ehsan Akhgari (needinfo? me!) from comment #18)
> There's no design behind any of this, not at least a recent one.  Please
> feel free to file a bug on that, but I probably won't have enough time to
> work on it myself.  Sorry!

Thanks for the info. I filed bug 915117.

Comment 20

[SevenFactors]

Why must the web browser comply to a website request to turn off the ability to use Firefox built in spell checker? 

Why should a website force us to use their WYSIWYG text editor's clunky spell checker? 

We know Firefox spell checker out-best them. Why take in-line as you type spell checking in multiple languages [dictionaries] away from your browser's end users? I don't understand why websites should be able mess with our browser settings and mess with our on-the-web text editing experience. It is our body of text and we should be able to spell check the heck out of it with Firefox's spell checker.

I don't see what was wrong with the previous behavior. Firefox built-in spell checker was off and the user had to turn it on [right click menu > spell check] it was not "On" Firefox was empowering its users by allowing them to still be able to use the built-in spell checker. Now we have been robbed of such empowering for-user yet harmless to-the-website setting

I see this as a big step backward, thus broken.

Comment 21

[Alain Knaff]

This is highly annoying, please restore the old behavior. What harm can it do to a webmaster if people can spellcheck their submissions to him?

Worst is if it's not even the webmaster's decision, but some software he had installed which had this nonsense in without anybody knowing (... not even the current developers of said software...)

See https://bugzilla.mozilla.org/show_bug.cgi?id=909352#c13 for one example.

Please, do the user's bidding, and don't lick up to big media, banks or whomever. Firefox, you are _our_ browser not theirs!

Comment 22

[(no longer active)]

A good example of a case where a website would legitimately want to disable spell checking on a field is when they use it to display text which is not meant to be entered by the suer, and hence does not require to be spell checked.  A classic example is a textarea showing the EULA for a website.

Comment 23

[Dão Gottwald [:dao]]

(In reply to :Ehsan Akhgari (needinfo? me!) from comment #22)
> A good example of a case where a website would legitimately want to disable
> spell checking on a field is when they use it to display text which is not
> meant to be entered by the suer, and hence does not require to be spell
> checked.  A classic example is a textarea showing the EULA for a website.

Such fields should be read-only, so the readonly attribute might be a better indicator than spellcheck="false" that the user shouldn't be able to enable spell checking.