622932 - tabRemoved only sent by TabItem when closed via Panorama

Status: RESOLVED WONTFIX

(Firefox Graveyard :: Panorama, defect)

Description

[Michael Yoshitaka Erlewine [:mitcho]]

Currently, the tabRemoved event is only sent by a TabItem to its subscribers if TabItem_close was run... i.e., if the tab was closed via the Panorama interface.

Most likely we would like to fire tabRemoved even if the tab was closed via some other programmatic (tabbrowser) mechanism, in which case we should be firing tabRemoved in TabItem_unlink instead.

Comment 1

[Michael Yoshitaka Erlewine [:mitcho]]

Actually, it looks like "close" is fired instead in TabItems_unlink already. So the question, I guess, is what is the TabItem "tabRemoved" event even doing? Looks like we aren't using it right now.

If it's an event for "tab was closed via Panorama interface", (a) it should be better labelled and (b) do we really need it?

Comment 2

[Ian Gilman [:iangilman]]

I believe it's being used in one of our tests... Raymond probably has a better answer as to its purpose. I'd be happy to lose it if we can refactor somehow.

Comment 3

[Raymond Lee [:raymondlee]]

Yes, "tabRemoved" is only used for one of our tests.  Firing tabRemoved in TabItems_unlink() is not appropriate  because TabItems_unlink() also get called when TabItems_handleTabPin().  Furthermore, when  tabbrowser module fires TabClose event and our TabItems_unlink() gets invoked, the browser tab is actually being closed but it still exists so it's not the right time to fire tabRemoved event in our code.

Comment 4

[Michael Yoshitaka Erlewine [:mitcho]]

Thanks Raymond. Something to think about for the future then. Should we mark this wontfix or future?

Comment 5

[Raymond Lee [:raymondlee]]

Lets mark this as wontfix and open a new bug if we really need the "tabRemoved" event in other places.

Comment 6

[Ian Gilman [:iangilman]]

Perhaps the event needs to have a better name, something that's longer and more explicit, so people don't mistake it for an actual API.