Closed Bug 623137 Opened 13 years ago Closed 13 years ago

Failed to build jsdbgapi.cpp with --disable-methodjit

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 623277

People

(Reporter: ginnchen+exoracle, Assigned: sfink)

References

Details

Attachments

(1 file)

+    if (!script->singleStepMode == !singleStep)
+        return JS_TRUE;

singleStepMode is only defined with JS_METHODJIT.
Assignee: general → sphink
OS: Mac OS X → All
Hardware: x86 → All
Attached patch Patch v0Splinter Review
Fixes (this instance of) build bustage and a related warning.

Sorry for the steal, sfink! I saw the bug and made the patch and when I came back you had taken it. With this patch, bug 623139 's patch, and another build failure (bug forthcoming) the --disable-methodjit shell builds and passes tests.
Attachment #501367 - Flags: review?(sphink)
Comment on attachment 501367 [details] [diff] [review]
Patch v0

Thanks! I was still messing around with my build environment anyway.
Attachment #501367 - Flags: review?(sphink) → review+
The other bug I mentioned is bug 623277 .
A different fix was already applied as part of bug 622503, and I'm consolidating these --disable-methodjit bugs.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: