623239 - Add on not getting installed

Status: RESOLVED INCOMPLETE

(addons.mozilla.org Graveyard :: Add-on Builder, defect)

Description

[Ayan Shah[:ashah]]

Saw this on stage - https://builder-addons-next.allizom.org
Env: Mac OS X, Firefox 4.0b8

When I press the Test button to install an add-on, it gives me the following error:

Error 500
Internal Server Error
500: Server error

Comment 1

[Piotr Zalewa [:zalun]]

Works for me - I guess it depends on #623065

Comment 2

[Piotr Zalewa [:zalun]]

Is it still happening?

Comment 3

[Ayan Shah[:ashah]]

Well, it happens sometimes. It happened today morning but right now, it is working fine.

Comment 4

[Piotr Zalewa [:zalun]]

I guess we may assume user will try to click on Test again - these errors will be logged and emailed to Wil - we will fix them as they will appear.

I'd move it to 0.8 if all agree?

Comment 5

[Daniel Buchner [:dbuc]]

What is the user-facing consequence of this? Will there be an error whenever someone clicks the test button when the test is being fetched?

If this is the case, why don't we just keep a ref to the onSuccess of the ajax call and switch that function out if there is another test press to effectively null out the test installation when the xpi arrives?

Comment 6

[Piotr Zalewa [:zalun]]

there will be an error

I find the other solution a hack - I don't think it's good

Comment 7

[Daniel Buchner [:dbuc]]

I am fine with addressing this in 0.8, but allowing for the abort of the action is not a hack, it is a normal thing. Perhaps calling onAbort or canceling the request would suffice, not sure.

Changed to 0.8

Comment 8

[Wil Clouser [:clouserw]]

This isn't something happening everywhere, so we'll need specific steps to reproduce this.  Please use actual URLs to your add-on.