Fix build errors w.r.t JS_GetStringChars

RESOLVED FIXED in 1.0b4

Status

defect
--
blocker
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: Fallen, Assigned: Fallen)

Tracking

unspecified
1.0b4
Bug Flags:
blocking-calendar1.0 +

Details

Attachments

(1 attachment)

Posted patch Fix - v1Splinter Review
This patch takes care, we need to use a function that passes a js context.

Alas, there have been more m-c changes that make Lightning frown, but this makes it compile again.
Flags: blocking-calendar1.0+
Attachment #501354 - Flags: review?(mschroeder)
Comment on attachment 501354 [details] [diff] [review]
Fix - v1

Looks good. r=mschroeder.

Only nit, JSID_TO_STRING(id) could be assigned to a variable (pointer) first for better visibility of the function call.
Attachment #501354 - Flags: review?(mschroeder) → review+
(Assignee)

Comment 2

9 years ago
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/2b4b40c2f1d1>
-> FIXED
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Trunk
You need to log in before you can comment on or make changes to this bug.