Closed
Bug 623257
Opened 14 years ago
Closed 14 years ago
Fix build errors w.r.t JS_GetStringChars
Categories
(Calendar :: Internal Components, defect)
Calendar
Internal Components
Tracking
(Not tracked)
RESOLVED
FIXED
1.0b4
People
(Reporter: Fallen, Assigned: Fallen)
Details
Attachments
(1 file)
|
2.38 KB,
patch
|
mschroeder
:
review+
|
Details | Diff | Splinter Review |
This patch takes care, we need to use a function that passes a js context.
Alas, there have been more m-c changes that make Lightning frown, but this makes it compile again.
Flags: blocking-calendar1.0+
Attachment #501354 -
Flags: review?(mschroeder)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 501354 [details] [diff] [review]
Fix - v1
Looks good. r=mschroeder.
Only nit, JSID_TO_STRING(id) could be assigned to a variable (pointer) first for better visibility of the function call.
Attachment #501354 -
Flags: review?(mschroeder) → review+
|
Assignee | |
Comment 2•14 years ago
|
||
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/2b4b40c2f1d1>
-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•