623330 - Intermittent failure in browser/base/content/test/tabview/browser_tabview_privatebrowsing.js | verify normal 1: we have 2 groups - Got 0, expected 2

Ian Gilman [:iangilman]

Assignee

Description

•

15 years ago

No description provided.

Phil Ringnalda (:philor)

Updated

•

15 years ago

Blocks: 438871

Whiteboard: [orange]

Phil Ringnalda (:philor)

Comment 1

•

15 years ago

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1294289392.1294290559.19748.gz Rev3 Fedora 12 mozilla-central opt test mochitest-other on 2011/01/05 20:49:52 s: talos-r3-fed-024 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_privatebrowsing.js | verify normal 1: we have 2 groups - Got 0, expected 2 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_privatebrowsing.js | verify normal 1: same number of tabs as groups TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_privatebrowsing.js | Test timed out TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_rtl.js | Tab View starts hidden TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_rtl.js | Test timed out TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_search.js | Tab View is hidden TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_rtl.js | Tab View is visible. TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_undo_group.js | Test timed out

Comment hidden (Legacy TBPL/Treeherder Robot)

Michael Yoshitaka Erlewine [:mitcho]

Comment 12

•

15 years ago

WHOAH, looks like, for whatever reason, this started suddenly picking up. Ian, you're looking at this?

Ian Gilman [:iangilman]

Assignee

Comment 13

•

15 years ago

Attached patch patch v1 — Details — Splinter Review

This is happening because we're not waiting until the tabs have been sorted out after the mode switch. I suspect this is due to my reliance on .webProgress.isLoadingDocument; switched to .contentDocument.readyState, which should be more reliable (catching even uninitialized tabs that haven't started loading yet).

Attachment #502116 - Flags: review?(dao)

Ian Gilman [:iangilman]

Assignee

Comment 14

•

15 years ago

I believe this may be the same cause for bug 604458; hopefully this patch will fix them both.

Blocks: 604458

Dão Gottwald [:dao]

Comment 15

•

15 years ago

Comment on attachment 502116 [details] [diff] [review] patch v1 This function seems flawed, it won't call back if all tabs are already loaded...

Comment hidden (Legacy TBPL/Treeherder Robot)

rcampbell%mozilla.com http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1294771064.1294772503.20418.gz Rev3 WINNT 5.1 mozilla-central opt test mochitest-other on 2011/01/11 10:37:44 s: talos-r3-xp-024 PROCESS-CRASH | Main app process exited normally | application crashed (minidump found) Thread 0 (crashed) PROCESS-CRASH | Main app process exited normally | application crashed (minidump found) Thread 0 (crashed) TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/browser_bug553455.js | Should have seen the install fail - Got addon-progress-notification, expected addon-install-failed-notification TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/browser_bug553455.js | Should have seen the right message - Got Add-on downloading, expected This add-on could not be installed because it appears to be corrupt. TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/browser_bug553455.js | Should be no active installs - Got 1, expected 0 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/browser_bug553455.js | Test timed out TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/browser_bug553455.js | Found a tab after previous test timed out: http://example.com/browser/toolkit/mozapps/extensions/test/xpinstall/installtrigger.html?%7B%22XPI%22%3A%22unsigned.xpi%22%7D TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/browser_bug553455.js | Should have seen the right window open - Got chrome://global/content/customizeToolbar.xul, expected chrome://mozapps/content/xpinstall/xpinstallConfirm.xul TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_privatebrowsing.js | verify normal 1: we have 2 groups - Got 0, expected 2 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_privatebrowsing.js | verify normal 1: same number of tabs as groups TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_privatebrowsing.js | Test timed out TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_rtl.js | Tab View starts hidden TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_rtl.js | Test timed out TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_search.js | Tab View is hidden TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_rtl.js | Tab View is visible. TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_undo_group.js | Test timed out

Ian Gilman [:iangilman]

Assignee

Comment 25

•

15 years ago

(In reply to comment #15) > Comment on attachment 502116 [details] [diff] [review] > patch v1 > > This function seems flawed, it won't call back if all tabs are already > loaded... Good point! I'll piggy back this on bug 624265 and use the version introduced there.

Depends on: 624265

Comment hidden (Legacy TBPL/Treeherder Robot)

joe%drew.ca http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1294809197.1294810563.23515.gz Rev3 WINNT 5.1 mozilla-central opt test mochitest-other on 2011/01/11 21:13:17 s: talos-r3-xp-034 PROCESS-CRASH | Main app process exited normally | application crashed (minidump found) Thread 0 (crashed) PROCESS-CRASH | Main app process exited normally | application crashed (minidump found) Thread 0 (crashed) TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_privatebrowsing.js | verify normal 1: we have 2 groups - Got 0, expected 2 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_privatebrowsing.js | verify normal 1: same number of tabs as groups TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_privatebrowsing.js | Test timed out TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_rtl.js | Tab View starts hidden TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_rtl.js | Test timed out TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_search.js | Tab View is hidden TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_rtl.js | Tab View is visible. TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_undo_group.js | Test timed out TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser/browser_464620_b.js | Test timed out TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser/browser_464620_b.js | Found a tab after previous test timed out: http://mochi.test:8888/browser/browser/components/sessionstore/test/browser/browser_464620_b.html

Comment hidden (Legacy TBPL/Treeherder Robot)

philringnalda%gmail.com http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1294823306.1294824719.21848.gz Rev3 WINNT 5.1 tracemonkey opt test mochitest-other on 2011/01/12 01:08:26 s: talos-r3-xp-004 PROCESS-CRASH | Main app process exited normally | application crashed (minidump found) Thread 0 (crashed) PROCESS-CRASH | Main app process exited normally | application crashed (minidump found) Thread 0 (crashed) TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/browser_bug553455.js | Should have seen the install fail - Got addon-progress-notification, expected addon-install-failed-notification TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/browser_bug553455.js | Should have seen the right message - Got Add-on downloading, expected This add-on could not be installed because it appears to be corrupt. TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/browser_bug553455.js | Should be no active installs - Got 1, expected 0 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_privatebrowsing.js | verify normal 1: we have 2 groups - Got 0, expected 2 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_privatebrowsing.js | verify normal 1: same number of tabs as groups TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_privatebrowsing.js | Test timed out TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_rtl.js | Tab View starts hidden TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_rtl.js | Test timed out TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_search.js | Tab View is hidden TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_rtl.js | Tab View is visible. TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_undo_group.js | Test timed out

Comment hidden (Legacy TBPL/Treeherder Robot)

Ian Gilman [:iangilman]

Assignee

Comment 32

•

15 years ago

This is fixed by a combination of bug 624265 and bug 610242.

Status: NEW → RESOLVED

Closed: 15 years ago

Resolution: --- → FIXED

Dão Gottwald [:dao]

Updated

•

15 years ago

Attachment #502116 - Flags: review?(dao)

Tracy Walker [:tracy]

Updated

•

15 years ago

Whiteboard: [orange] → [orange][qa-]

Nobody; OK to take it and work on it

Updated

•

13 years ago

Keywords: intermittent-failure

Nobody; OK to take it and work on it

Updated

•

13 years ago

Whiteboard: [orange][qa-] → [qa-]

Nobody; OK to take it and work on it

Updated

•

10 years ago

Product: Firefox → Firefox Graveyard