623431 - Remove ImageUploadFormAsync and VideoUploadFormAsync

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task, P4)

Description

[Paul Craciunoiu [:paulc]]

ImageUploadFormAsync and VideoUploadFormAsync are not necessary.

Uploading a draft should be handled as part of the form's clean() method. It might even be possible to get away with a, e.g.:
image = image_form.save()
and be done with it, leaving the all the upload logic to the model form.

While at it, the video validation does not check extensions in VideoUploadForm.clean, but it does so in VideoUploadFormAsync.clean
(not an actual problem since the latter must validate first).

Since bug 623429 makes handling drafts simpler, I'm adding that as a dependency.

Comment 1

[Paul Craciunoiu [:paulc]]

There's more important stuff on our plate right now and this can wait.

Comment 2

[Paul Craciunoiu [:paulc]]

I'm working on the refactoring and I've already done this part, so => 2.6

Comment 3

[James Socol [:jsocol, :james]]

Paul, is this done or should it move out?

Comment 4

[Paul Craciunoiu [:paulc]]

It's long done on my branch, which fully refactors the gallery frontend as well. I'd rather avoid complications, though, and it's not urgent at all.

Comment 5

[Paul Craciunoiu [:paulc]]

Fixed as part of bug 650407, commit:
https://github.com/jsocol/kitsune/compare/161eecfa1d07d1882cea...138a46776caf2a2fa8d4

Comment 6

[Rebecca Billings [:rbillings]]

Closed as [qa-]