"Assertion failed at gfx/cairo/cairo/src/cairo-surface.c:588: CAIRO_REFERENCE_COUNT_HAS_REFERENCE (&surface->ref_count)" for shadow canvas and video OGL layers with

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: cjones, Assigned: cjones)

Tracking

unspecified
x86_64
Linux
Points:
---

Firefox Tracking Flags

(fennec2.0b4+)

Details

Attachments

(1 attachment, 2 obsolete attachments)

The problem is that we swap front/back on updates, but with GL we only use one surface and end up double-releasing.  Pretty simple fix.
Use-after-free bug.
tracking-fennec: --- → ?
Posted patch Don't double-release surfaces (obsolete) — Splinter Review
Not sure what the proper COM discipline is for this situation, but this patch doesn't make me vomit in my mouth /too/ much.
Assignee: nobody → jones.chris.g
Attachment #501574 - Flags: review?
Attachment #501574 - Flags: review? → review?(vladimir)
Oops, obviously ignore that hunk in cairo/src.
Comment on attachment 501574 [details] [diff] [review]
Don't double-release surfaces

you want jeff here.. and you also want someone to do the cairo patch dance (as well as getting rid of the extra whitespace :-)
Attachment #501574 - Flags: review?(vladimir) → review?(jmuizelaar)
That cairo hunk was just for my debugging purposes, I didn't mean to include it.  Let me post a version with it removed.
Nix the debugging code.
Attachment #501574 - Attachment is obsolete: true
Attachment #501577 - Flags: review?(jmuizelaar)
Attachment #501574 - Flags: review?(jmuizelaar)
Sigh.
Attachment #501577 - Attachment is obsolete: true
Attachment #501578 - Flags: review?(jmuizelaar)
Attachment #501577 - Flags: review?(jmuizelaar)

Updated

8 years ago
tracking-fennec: ? → 2.0b4+
Attachment #501578 - Flags: review?(jmuizelaar) → review+
http://hg.mozilla.org/mozilla-central/rev/7cad0cd7b62e
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.