623665 - Sync botches sessions for History

Status: RESOLVED WONTFIX

(Firefox :: Sync, defect)

Description

[Shawn Wilsher :sdwilsh]

Places has a concept of a session which basically maps to the navigation in a tab.  Every page that is loaded in it has the same session (sorta, it's complicated).  Right now, when Sync adds visits to other computers, it passes in 0 for the session id (a reasonable thing to do, probably).  However, this makes sessions rather useless.

Sync can't do much better unless Places changes how it tags sessions to use a GUID so it'd be unique across computers (would need to file a new Places bug for that).  It's also possible that we just want to drop the concept all together (in which case, this bug gets WONTFIXed and we file a new Places bug).

Comment 1

[Mike Connor [:mconnor]]

Do we really use the session concept for anything in Places?  I remember when we added it, but I don't think we ever really managed to do something useful with it, which I suspect is the reason no one's noticed this before.

Comment 2

[Shawn Wilsher :sdwilsh]

(In reply to comment #1)
> Do we really use the session concept for anything in Places?  I remember when
> we added it, but I don't think we ever really managed to do something useful
> with it, which I suspect is the reason no one's noticed this before.
I don't believe we do, and mak and I have talked about removing it in the past.  I'd be interested in hearing what mak and dietrich have to say about this.

Comment 3

[Dietrich Ayala (:dietrich)]

IIRC we removed the only usage of it (history sidebar) long ago. We discussed removing the functionality from the backend too. The only repercussion this might have is on extensions that are using the functionality.

Comment 4

[Richard Newman [:rnewman]]

WONTFIX per discussion.