624123 - Titlebar too big after leaving full screen if tab groups were used [tabs in titlebar]

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Vykintas Vyšniauskas]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; rv:2.0b9pre) Gecko/20110107 Firefox/4.0b9pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; rv:2.0b9pre) Gecko/20110107 Firefox/4.0b9pre

If the window is maximized and Tabs on Top are enabled, leaving full screen results in a too big titlebar if Tab Groups were used.

Reproducible: Always

Steps to Reproduce:
1. Have tabs drawn in titlebar ('Tabs on Top' enabled and window maximized)
2. Hit F11 to enter full screen
3. Hit Ctrl+E to enter Tab Groups
4. Hit Esc to leave Tab Groups
5. Hit F11 to leave full screen
Actual Results:  
The titlebar is way too big.

Expected Results:  
It should be normal.

Comment 1

[Vykintas Vyšniauskas]

Attachment: screenshot showing big titlebar

Comment 2

[redsign]

Confirmed!

Comment 3

[Alice0775 White]

Confirmed on latest hourly.
http://hg.mozilla.org/mozilla-central/rev/df3c1150dd7a
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b9pre) Gecko/20110107 Firefox/4.0b9pre ID:20110108005407

It happens with Aero，Aero Basic, Classic. and Luna too.

Comment 4

[Tan Wei Lin Jason [:Ryuji]]

Confirmed on Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b9pre) Gecko/20110108 Firefox/4.0b9pre

Comment 5

[Donald]

Confirmed on Mozilla/5.0 (Windows NT 5.1; rv:2.0b9pre) Gecko/20110108 Firefox/4.0b9pre.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

I can't reproduce this on Windows 7 :/

Comment 7

[Asa Dotzler [:asa]]

I can reproduce this on windows as long as I perform steps 2, 3, and 4 without any intermediary actions. It's easily fixed by leaving restoring the window and re-maximizing though. Needs to be fixed for final but I don't think it should block b9.

Comment 8

[Dão Gottwald [:dao]]

Attachment: patch

tested on Win XP and 7

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Why was the bug occurring and why does that fix it?

Comment 10

[Tan Wei Lin Jason [:Ryuji]]

I can reproduced it in Windows 7. Hence this also affect Windows 7.

Comment 11

[Dão Gottwald [:dao]]

tabview/ui.js calls TabsInTitlebar.allowedBy("tabview-open", ...), but the calculations in TabsInTitleBar._update fail when the toolbars are moved off-screen. The patch prevents tabs in the titlebar from being toggled while the fullscreen UI is active.

Comment 12

[:Gavin Sharp [email: [e-mail]]]

With this patch applied, the title bar seems to be sized incorrectly after transitioning out of fullscreen and into maximized state (or possibly only maximized->fullscreen->maximized).

Comment 13

[Dão Gottwald [:dao]]

(In reply to comment #12)
> With this patch applied, the title bar seems to be sized incorrectly after
> transitioning out of fullscreen and into maximized state (or possibly only
> maximized->fullscreen->maximized).

I think I saw this problem when I implemented tabs in the titlebar. Not sure why I didn't see it now. Anyway, the problem is that the fullscreen event is dispatched before the actual mode change, so the measurements can be off.

Comment 14

[Dão Gottwald [:dao]]

Attachment: patch v2

Slightly different approach, disables all updates in fullscreen mode.

Comment 16

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/e1a0d3b39846

Comment 18

[Steve Scott (pxbugz)]

Verified fixed in Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b12pre) Gecko/20110204 Firefox/4.0b12pre

Comment 19

[[e-mail]]

It's fixed, I can confirm.