62431 - Mousewheel should only scroll scrollable textareas

Status: RESOLVED WORKSFORME

(Core :: XUL, defect)

Description

[Blake Ross]

The mousewheel should only scroll a textarea if it has scrollbars.  It 
currently tries to scroll it even when it doesn't, which means nothing happens 
if the cursor happens to be over, say, an empty textarea.

Comment 1

[Brian Ryner (not reading)]

This should only be happening if the text area has focus, I would think...

Comment 2

[Brian Ryner (not reading)]

Accepting, although I don't see this one as really high priority.

Comment 3

[Akkana Peck]

This applies to single-line text fields, too.  Many times a day I curse at
mozilla in bugzilla pages because I type something, then try to wheel-scroll,
then realize that I have to click outside the text field first.  It would SO
enhance usability if this was fixed ... can I help?

Comment 4

[Akkana Peck]

See also bug 27771, on the same problem as it relates to page up/down.  Bryner
suggests that nsGfxTextControlFrame2::GetScrollableView should return the parent
if the text conrol is not scrollable, which sounds very sensible, and I'm going
to play with that and see if it fixes the problem (with luck, it'll fix both bugs).

Comment 5

[Blake Ross]

I have a fix for the input field part.  I'm not yet sure how to determine if 
the textarea overflows.

Comment 6

[Blake Ross]

Attachment: [patch] don't scroll input fields

Comment 7

[Blake Ross]

Just realized that ::GetClosestScrollableView needs to be returning an 
NS_IMETHOD for correctness (per its prototype). fixed.

by the way, this doesn't fix the pgup/dn bug.  GetScrollableView is never 
reached, probably because editor is bailing somewhere beforehand.

Comment 8

[Blake Ross]

errr, NS_IMETHODIMP.

Comment 9

[Blake Ross]

Attachment: [patch] simplified

Comment 10

[Blake Ross]

Attachment: [patch] suggestions by akkana (r=akkana)

Comment 11

[Brian Ryner (not reading)]

r=bryner

Comment 12

[Jan Carpenter]

not my area, best guess reassigning to jrgm

Comment 13

[Keyser Sose]

*** Bug 80014 has been marked as a duplicate of this bug. ***

Comment 14

[Jesse Ruderman]

See also bug 42313, Unable to scroll with mousewheel over objects contained in 
IFRAMEs.

Comment 15

[Peter Trudelle]

Mass moving lower-priority bugs to 0.9.6 (with Blake's pre-consent) to make room
for remaining 0.9.4/eMojo bugs and MachV planning, performance and feature work.
 If anyone disagrees with the new target, please let me know.

Comment 16

[Pascal Chevrel:pascalc]

removing Mozilla1.01 target

Comment 17

[Pascal Chevrel:pascalc]

*** Bug 140074 has been marked as a duplicate of this bug. ***

Comment 18

[Patrick]

ok it works now

Comment 19

[Boris Zbarsky [:bzbarsky]]

This caused bug 209807 

Comment 20

[R.K.Aa.]

*** Bug 185121 has been marked as a duplicate of this bug. ***

Comment 21

[Martijn Wargers (dead)]

WF in current trunk build, shouldn't this be resolved WFM?

Comment 22

[José Jeria]

WFM too

Please reopen if you can reproduce with a trunk build