Closed
Bug 624376
Opened 15 years ago
Closed 15 years ago
Remove unused member - nsHttpConnection:mLock
Categories
(Core :: Networking: HTTP, defect)
Core
Networking: HTTP
Tracking
()
RESOLVED
FIXED
People
(Reporter: mcmanus, Assigned: mcmanus)
Details
Attachments
(1 file)
|
2.83 KB,
patch
|
mayhemer
:
review+
jst
:
approval2.0+
|
Details | Diff | Splinter Review |
nsHttpConnection defines, initializes, and destroys a PR_Lock - mLock.
But that lock is never locked or unlocked or used in any way.
|
Assignee | |
Updated•15 years ago
|
Assignee: nobody → mcmanus
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•15 years ago
|
||
Attachment #502479 -
Flags: review?(jduell.mcbugs)
|
||
Updated•15 years ago
|
Attachment #502479 -
Flags: review?(jduell.mcbugs) → review?(honzab.moz)
|
||
Comment 2•15 years ago
|
||
Comment on attachment 502479 [details] [diff] [review]
remove unused prlock v1
Good catch. This simple patch could potentially get it to Fx4.
r=honzab.
Attachment #502479 -
Flags: review?(honzab.moz)
Attachment #502479 -
Flags: review+
Attachment #502479 -
Flags: approval2.0?
|
||
Updated•15 years ago
|
Attachment #502479 -
Flags: approval2.0? → approval2.0+
|
|
||
Comment 3•15 years ago
|
||
Checked in, and I just realized that the checkin comment in the patch referred to the wrong bug (bug 624374).
http://hg.mozilla.org/mozilla-central/rev/4753f5a91e75
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•