624394 - Version 3.1 loses ability to customize titlebar with just window title

Status: RESOLVED FIXED

(Other Applications Graveyard :: Nightly Tester Tools, defect)

Description

[David Rees]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.13) Gecko/20101203 Firefox/3.6.13 (.NET CLR 3.5.30729)
Build Identifier: Nightly Tester Tools 3.1, Firefox 3.6.13

In moving from 2.0.3 to 3.1 in terms of Customize Titlebar there is a change in customize titlebar that results in a loss of functionality.

In 2.0.3 the customization string "DevFirefox" would always append the window title so the titlebar would end up being "DevFirefox - yahoo.com".

In 3.1 there no longer seems to be a way to getting a titlebar and the page title without the product name.

"DevFirefox" gives a window title of just "DevFirefox".
"${DefaultTitle} - DevFireBug" gives a window title of "Yahoo! - Mozilla Firefox - DevFirefox"

So there is no longer a way to get the same functionality as 2.1 where you just have the window title and a custom string.

Perhaps there should be a variable named ${PageTitle} that just does the page title? So the user could do:
"${PageTitle} - DevFireBug" gives a window title of "Yahoo! - DevFirefox"


There 

Is there something like a
${title} option by any chance? I know there is ${defaulttitle}, but that gives
you Mozilla Firefox as well (which makes it harder to distinguish from the
non-dev titles).



Reproducible: Always

Comment 1

[Szabolcs Hubai (:xabolcs)]

Hi there,


I implemented this with a new `DefaultTitlePrefix` variable for Firefox and Thunderbird.
Proposals to name this new variable are welcome!

See GitHub pull request #9:
https://github.com/mozilla/nightlytt/pull/9


Thank You,
Szabolcs

Comment 2

[Szabolcs Hubai (:xabolcs)]

Attachment: introducing nightlyApp.currentTabTitle v1

If it is feasible to You (to users, to the Reporter, to authors) to customize 
with the current tab's title, then here is the patch. :)
If not (for e.g. to be more closer to tabbrowser's and tabmail's title calculating), then the currentTabTitle() should be improved.

By the way who would like to be the r?

Comment 3

[Szabolcs Hubai (:xabolcs)]

I forgot to mention that this v1 patch should be applied to 
the top of Bug 717192 - Part 2: cleanup patch.

So please prioritize the other bug first! :)

Comment 4

[Szabolcs Hubai (:xabolcs)]

Attachment: patch in action - Thunderbird

Adding screenshot.

Comment 5

[Szabolcs Hubai (:xabolcs)]

Attachment: patch in action - Firefox

Adding screenshot.

Comment 6

[Szabolcs Hubai (:xabolcs)]

(In reply to Szabolcs Hubai from comment #2)
> Created attachment 594842 [details] [diff] [review]
> introducing nightlyApp.currentTabTitle v1
> 
> If it is feasible to You (to users, to the Reporter, to authors) to
> customize 
> with the current tab's title, then here is the patch. :)
> If not (for e.g. to be more closer to tabbrowser's and tabmail's title
> calculating), then the currentTabTitle() should be improved.
> 
> By the way who would like to be the r?

Pinging someone in #ateam to assign this bug to me, and to select somebody to review the patch.

Comment 7

[Tony Mechelynck [:tonymec]]

Comment on attachment 594842 [details] [diff] [review]
introducing nightlyApp.currentTabTitle v1

(In reply to Szabolcs Hubai from comment #6)
[...]
> Pinging someone in #ateam to assign this bug to me, and to select somebody
> to review the patch.

You're now ASSIGNED. Heather, Henrik, whoever of you two comes around first to review the patch may remove the other. Or of course, if you think that some other reviewer would be better qualified, feel free to change the reviewer's name.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Similar to the other bug, would you mind to transfer the patch over to a github pull request? 

https://github.com/mozilla/nightlytt/pulls

We are considering to get rid of the Bugzilla component in favor of handling everything directly via github. I would be happy to have a look at your patch as soon as it will be available as pull request. Thanks.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 594842 [details] [diff] [review]
introducing nightlyApp.currentTabTitle v1

We take care of reviews on Github now. So clearing the requests.

Comment 10

[Szabolcs Hubai (:xabolcs)]

Comment on attachment 594842 [details] [diff] [review]
introducing nightlyApp.currentTabTitle v1

landed with assigned nits:

https://github.com/mozilla/nightlytt/commit/2b93970caf2ca4d4c7fd8025441707768754ac9f

https://github.com/mozilla/nightlytt/commit/c3063347324b0908049ccb3a825f076770c17093

Comment 11

[David Rees]

Nice, looks good. Thanks!