624411 - Accessing HTTPS URLs causes "Invalid use of the preferences on a background thread!" warning

Status: VERIFIED DUPLICATE of bug 624514

(Core :: Security: PSM, defect)

Description

[Ben Bucksch (:BenB)]

We make HTTPS calls using XMLHttpRequest from JS, and get the warning:
"Invalid use of the preferences on a background thread!" (introduced in bug 619487).

Using a debug build, we got the following stack. This is a bug in PSM in that it reads the pref "security.OCSP.enabled" from a background thread, but it's not supposed to do that.



[Switching to Thread 0x7fffdb745710 (LWP 31906)]

Breakpoint 1, nsPrefService::CheckAndLogBackgroundThreadUse ()
    at /home/laga/work/firefox/source/modules/libpref/src/nsPrefService.cpp:983
983       NS_WARNING("Cannot be used on a background thread!");
(gdb) bt
#0  nsPrefService::CheckAndLogBackgroundThreadUse ()
    at /home/laga/work/firefox/source/modules/libpref/src/nsPrefService.cpp:983
#1  0x00007ffff4cd5ce5 in nsPrefBranch::GetIntPref (this=0x7fffebbee400,
    aPrefName=0x7ffff6cba37b "security.OCSP.enabled", _retval=0x7fffdb7443ac)
    at /home/laga/work/firefox/source/modules/libpref/src/nsPrefBranch.cpp:235
#2  0x00007ffff4cde999 in nsPrefService::GetIntPref (this=0x7fffe6861920,
    aPrefName=0x7ffff6cba37b "security.OCSP.enabled", _retval=0x7fffdb7443ac)
    at /home/laga/work/firefox/source/modules/libpref/src/nsPrefService.h:62
#3  0x00007ffff5ca503b in nsNSSCertificateDB::GetIsOcspOn (this=0x7fffd389c420,
    aOcspOn=0x7fffdb74470c)
    at /home/laga/work/firefox/source/security/manager/ssl/src/nsNSSCertificateDB.cpp:1368
#4  0x00007ffff5cb36fb in nsNSSCertificate::hasValidEVOidTag (this=0x7fffd39ce680,
    resultOidTag=@0x7fffdb7447c8, validEV=@0x7fffdb74487c)
    at /home/laga/work/firefox/source/security/manager/ssl/src/nsIdentityChecking.cpp:1018
#5  0x00007ffff5cb3ae5 in nsNSSCertificate::getValidEVOidTag (this=0x7fffd39ce680,
    resultOidTag=@0x7fffdb7447c8, validEV=@0x7fffdb74487c)
    at /home/laga/work/firefox/source/security/manager/ssl/src/nsIdentityChecking.cpp:1125
#6  0x00007ffff5cb3bf6 in nsNSSCertificate::GetIsExtendedValidation (this=0x7fffd39ce680,
    aIsEV=0x7fffdb74487c)
    at /home/laga/work/firefox/source/security/manager/ssl/src/nsIdentityChecking.cpp:1151
#7  0x00007ffff5c53403 in AuthCertificateCallback (client_data=0x0, fd=0x7fffdc2fc1f0,
    checksig=1, isServer=0)
    at /home/laga/work/firefox/source/security/manager/ssl/src/nsNSSCallbacks.cpp:1014
#8  0x00007fffef5f7795 in ssl3_HandleCertificate (ss=0x7fffdf53c000,
    b=0x7fffdf529360 "\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\24
5\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245\245"...,
    length=0) at ssl3con.c:7904
#9  0x00007fffef5f92b1 in ssl3_HandleHandshakeMessage (ss=0x7fffdf53c000,
    b=0x7fffdf529004 "", length=860) at ssl3con.c:8603
#10 0x00007fffef5f9719 in ssl3_HandleHandshake (ss=0x7fffdf53c000, origBuf=0x7fffdf53c368)
    at ssl3con.c:8727
#11 0x00007fffef5fa2ff in ssl3_HandleRecord (ss=0x7fffdf53c000, cText=0x7fffdb744bc0,
    databuf=0x7fffdf53c368) at ssl3con.c:9066
#12 0x00007fffef5fb4a0 in ssl3_GatherCompleteHandshake (ss=0x7fffdf53c000, flags=0)
    at ssl3gthr.c:209
#13 0x00007fffef5fe21f in ssl_GatherRecord1stHandshake (ss=0x7fffdf53c000) at sslcon.c:1258
#14 0x00007fffef60a2cb in ssl_Do1stHandshake (ss=0x7fffdf53c000) at sslsecur.c:151
#15 0x00007fffef60c6bd in ssl_SecureSend (ss=0x7fffdf53c000,
    buf=0x7fffdc3f5850 "GET /abc.html HTTP/1.1\r\nHost: secure.abcd.com\r\nUser-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:2.0b9pre) Gecko/20110110 Firefox/4.0b9pre\r\nAc"..., len=427, flags=0) at sslsecur.c:1213
#16 0x00007fffef60c877 in ssl_SecureWrite (ss=0x7fffdf53c000,
e=20110110 HTTP/1.1\r\nHost: a.abcd.com\r\nUser-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:2.0b9pre) Gecko/20110110 Firefox/4.0b9pre\r\nAc"..., len=427) at sslsecur.c:1258
#17 0x00007fffef614892 in ssl_Write (fd=0x7fffdc2fc1f0, buf=0x7fffdc3f5850, len=427)
    at sslsock.c:1652
#18 0x00007ffff5c4d03e in nsSSLThread::Run (this=0x7fffdc575b00)
    at /home/laga/work/firefox/source/security/manager/ssl/src/nsSSLThread.cpp:1045
#19 0x00007ffff5c4b193 in nsPSMBackgroundThread::nsThreadRunner (arg=0x7fffdc575b00)
    at /home/laga/work/firefox/source/security/manager/ssl/src/nsPSMBackgroundThread.cpp:44
#20 0x00007ffff397998f in _pt_root (arg=0x7fffdc511030)
    at /home/laga/work/firefox/source/nsprpub/pr/src/pthreads/ptthread.c:187
#21 0x00007ffff7bc8cb0 in start_thread () from /lib/libpthread.so.0
#22 0x00007fffefe2b9dd in clone () from /lib/libc.so.6
#23 0x0000000000000000 in ?? ()

Comment 1

[Ben Bucksch (:BenB)]

xref bug 624315

Comment 2

[Ben Bucksch (:BenB)]

xref bug 585706

Comment 3

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

This will be fixed by the patch that fixes bug 624514.

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to comment #3)
> This will be fixed by the patch that fixes bug 624514.

resolving as a dupe then