Closed Bug 6246 Opened 25 years ago Closed 25 years ago

[PP] Styled text is offset leftwards, only on Mac OS

Categories

(Core :: Layout, defect, P3)

PowerPC
Mac System 8.5
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: elig, Assigned: pierre)

References

Details

* TITLE/SUMMARY
[PP] Styled text is offset leftwards, only on Mac OS

(Simon Fraser originally pointed this out)

* STEPS TO REPRODUCE
0) Launch Apprunner
1) View Demo 0 (samples/test0.html)

* RESULT
 - What happened

All boldfaced, struckthrough, underlined, italicized, colored etc, text, is
offset about 3-10 pixels leftwards, and frequently overlaps with the preceeding
text.

 - What was expected

Behavior equivalent to Win32/Linux builds. I assume this is a known issue, but
can't find a bug, so in it goes...

* REGRESSION

 - Occurs On
        Mac OS Apprunner (5.10.99 AM, 5.11.99 AM optimized builds)

 - Doesn't Occur On
        Win32 & Linux Apprunner (5.11.99 AM optimized build)


* CONFIGURATIONS TESTED

- [Mac] Power Mac 8500/120 (233 Mhz 604e), 64 MB RAM (VM on; 1 MB of VM used),
1024x768 (Thousands of Colors), Mac OS 8.6

- [Win32] Vectra VL (233 Mhz P2), 96 MB RAM, 800x600 (True Color), NT 4.0 SP3.

- [Linux] Vectra VL (266 Mhz P2), 96 MB RAM.
QA Contact: 4144 → 1698
[QA Assigning to self, since Petersen was drowning in bugs last time I checked;
Chris, please reassign back to you if you feel strongly. ;-]
Assignee: rickg → kipp
Kipp-- this one would be a good one to track down before your sabbatical, if
possible. (You lucky dog).
cc: pierre and ftang, in case this has to do with font rendering changes.
Assignee: kipp → pierre
This has to be a rendering issue...Reassigning to pierre to track down. Layout
is XP, after all.
Status: NEW → ASSIGNED
Target Milestone: M7
This is odd, because it doesn't happen in viewer. I wonder if it has something
to do with the screen resolution pref.
Actually, text widths in viewer are screwed up too. Go into visual debugging
mode, and you'll see that in many frames, the frame is either wider or
narrower than the text contained therein. This causes the excessive space
before the style words "e.g. the first 'bold'", and messes up the justified text
also.
*** Bug 6575 has been marked as a duplicate of this bug. ***
The bug comes from an optimization that I have done a couple of weeks ago and
which consists in caching the width of the space character. Problem: when the
space character is measured, the font isn't set properly and the measurement is
done with the previous font settings.

The fix consists in 3 lines that set the current font. Waiting for approval to
check it in for M6.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Fixed. The fix is actually a bit longer than the 3 lines mentioned above: the
font/size/face are saved and restored.
Status: RESOLVED → VERIFIED
Verified fixed in 5.25.99 M6 candidate build. Thanks!
*** Bug 6400 has been marked as a duplicate of this bug. ***
You need to log in before you can comment on or make changes to this bug.