624602 - Add-ons manager should display add-ons licenses

Status: RESOLVED WONTFIX

(Toolkit :: Add-ons Manager, enhancement)

Description

[antistress]

User-Agent:       Mozilla/5.0 (X11; Linux x86_64; rv:2.0b9pre) Gecko/20110109 Firefox/4.0b9pre
Build Identifier: 

Not only the add-ons managershould display EULA for available add-ons that have one (Bug 605499) but the add-on manager should be able to display the add-on license on user demand.
The add-on manager is designed to be autonomous therefore the user shoud be able to get that information without having to surf the Web

Thanks

Reproducible: Always

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

Is the license information already be part of the 1.5 version of the AMO API?

Comment 3

[[:Aleksej]]

This is exacerbated by the fact that entries for add-ons from AMO do not always link to the AMO page: bug 638992 comment 7.

Comment 5

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Marco: Looks like we need this for bug 1007336, so I'm picking it up.

Comment 6

[Marco Mucci [:MarcoM]]

Added to Iteration 34.2.  Blair, can you provide a point value and if the bug should be marked as [qa+] or [qa-] for verification.

Comment 7

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Oops, sorry!

Comment 8

[:Gavin Sharp [email: [e-mail]]]

I think we decided to drop this again?

Comment 9

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Oh, yes, forgot to update the bug.

In the few hours awhile we had this as a blocker to bug 1007336, I had the implementation done. So I'll just finish this off by adding a couple of tests over the weekend.

Comment 10

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Ugh, forgot I need to pick this up again, as it came up as rather holy-crap-important bug in respect to bug 1039028.

And the requirements have changed a little, since we need to be able to link to a local file. So upping the points value.

Comment 11

[:Gavin Sharp [email: [e-mail]]]

Bug 1039028 seems to have a fine temporary solution, so this doesn't seem holy-crap-important. What am I missing?

Comment 12

[Blair McBride [:Unfocused] (UNAVAILABLE)]

I guess it could wait a release. But the solution we have in bug 1039028 is a bit awful in terms of UX and l10n. Saying that, it's not primary UI. But it's also not ideal in terms of adhering to the licensing terms, so there's some pressure to make things better merely from that perspective.

Comment 13

[:Gavin Sharp [email: [e-mail]]]

The solution we have doesn't seem that awful to me, and the problem is mostly one of legal compliance, not a huge user pain point. So I still don't think it worth it to invest in this at the expense of our other current priorities.

Comment 14

[Stephen A Pohl [:spohl]]

FYI: For Adobe EME, the "License Information" link will point to a static URL on Adobe servers (see bug 1129721). I don't know whether or not Adobe will implement locale detection on the backend and display a localized version of the license when appropriate, but it doesn't seem like that would be too difficult to do. I thought I'd mention it here in case we'd like to implement this for OpenH264.

(In reply to antistress from comment #0)
> The add-on manager is designed to be autonomous therefore the user shoud be
> able to get that information without having to surf the Web

Since the "License Information" link is clearly identifiable as a link, there shouldn't be any expectation that a click on this link wouldn't make a web request. You may compare this to the "Homepage" URL in the same pane: it too will make a web request when clicked.

Comment 15

[Blair McBride [:Unfocused] (UNAVAILABLE)]

*sigh* No time in the foreseeable future to work on this.

I'm sure I started this, but I can find any trace of a patch :\

Comment 16

[Till Schneidereit [:till]]

We need either this fixed or an extension of the hack in bug 1039028 for Shumway.

Comment 17

[Daniele "Mte90" Scasciafratte]

Discussion revamped on https://github.com/mozilla/addons/issues/211

Comment 18

[Andrew Swan [:aswan]]

We show (links to) licenses for GMP through eg bug 1039028.
We don't have any license information to show for webextensions...