624639 - Arrows in Bookmarks panel shouldn't change direction until mouse release

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[David Hsu]

User-Agent:       Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b9pre) Gecko/20110110 Firefox/4.0b9pre
Build Identifier: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b9pre) Gecko/20110110 Firefox/4.0b9pre

Right now, upon mousedown, the arrows in bookmarks arrow panel flip upside down instantly. They should remain their direction until the user release their mouse button.

See the screenshot for comparison with Windows.

Reproducible: Always

Comment 1

[David Hsu]

Attachment: screenshot

Note the 'pressed' state.

Comment 2

[Stefan [:stefanh]]

Confirming. Fwiw, the current behavior is not consistent with the native ones or the ones in the places window.

Comment 3

[Stefan [:stefanh]]

Attachment: Fix hover:active state

OK, so I think when this was added the idea was to overrule the hover:active icon in editBookmarkOverlay.css. However, the ".expander-down:hover:active" selector is of lower specificity than the "#editBookmarkPanel .expander-down" selector.

Comment 4

[Stefan [:stefanh]]

Comment on attachment 508477 [details] [diff] [review]
Fix hover:active state

Really safe ui-glitch fix.

Comment 5

[Stefan [:stefanh]]

(In reply to comment #3)
> OK, so I think when this was added the idea was to overrule the hover:active
> icon in editBookmarkOverlay.css.

Actually, probably not since then I guess the same directions would have been used.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 508477 [details] [diff] [review]
Fix hover:active state

a=beltzner, zero risk

Comment 7

[Stefan [:stefanh]]

http://hg.mozilla.org/mozilla-central/rev/553f7b1974a3

Comment 8

[Teodosia Pop]

Verified using Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b12pre) Gecko/20110220 Firefox/4.0b12pre ID:20110220030351.