[Mac Default] - Style the bookmarks arrow panel

RESOLVED FIXED in seamonkey2.1b2

Status

SeaMonkey
Themes
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: stefanh, Assigned: stefanh)

Tracking

Trunk
seamonkey2.1b2
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 3 obsolete attachments)

(Assignee)

Description

7 years ago
The bookmarks panel was turned into an arrow panel in bug 590105. We need to style this panel properly on mac.
(Assignee)

Updated

7 years ago
Depends on: 590105
(Assignee)

Comment 1

7 years ago
Created attachment 498522 [details] [diff] [review]
WIP

This is all styling that's needed - ported from firefox. The only thing I've changed is some code-wise styling (also note that firefox uses pre-defined stuff in shared.inc which I had to excerpt)
(Assignee)

Comment 2

7 years ago
Created attachment 498556 [details] [diff] [review]
WIP2

Fixed some indentation, added html namespace & credits
Attachment #498522 - Attachment is obsolete: true
(Assignee)

Comment 3

7 years ago
jftr, our star icons doesn't really fit here and we should have a larger icon in the panel imo.
(Assignee)

Comment 4

6 years ago
Created attachment 498652 [details] [diff] [review]
v1.0

OK, so this is ready now. This is basically a straight port from Firefox's browser.css, main differences are:

- removed a lot of unneeded important rules (the ones that are left are needed)
- slightly different structure, elements with the same rules are put together (e.g hover:active, focus etc), I omitted the navigator-specific ones, since I think it's better to have them separate from a maintenance pow.

browser.css can btw probably live without the sorting, because they have shared.inc where they put the common rules.

Oh, then I discovered that our placeholder isn't set on the tags field - it almost got me mad, because I first thought that some style rule was wrong.

The focus ring on the +-button isn't 100% right, but it looks like that in FF as well and I haven't been able to fins out what's happening.
Attachment #498556 - Attachment is obsolete: true
Attachment #498652 - Flags: review?(mnyromyr)
(Assignee)

Updated

6 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 5

6 years ago
Created attachment 498655 [details] [diff] [review]
v1.0 for real

Whoops, forgot that I had a little hack in there - this one should be the right one.
Attachment #498652 - Attachment is obsolete: true
Attachment #498655 - Flags: review?(mnyromyr)
Attachment #498652 - Flags: review?(mnyromyr)
(Assignee)

Comment 6

6 years ago
Created attachment 498656 [details]
screenshots, before and after

Comment 7

6 years ago
This is nice, could you file a bug to have this done for non-Mac as well? We're missing a similar set of rules in the normal default theme files.
(Assignee)

Comment 8

6 years ago
(In reply to comment #7)
> This is nice, could you file a bug to have this done for non-Mac as well? We're
> missing a similar set of rules in the normal default theme files.

Filed bug 620417.

Comment 9

6 years ago
Comment on attachment 498655 [details] [diff] [review]
v1.0 for real

Nice!
But the "New Folder" button should have a tooltip - I involuntarily added a new folder to my bookmarks (which I couldn't even delete in that dialog!), because the function of that [+] is totally non-obvious.

r=me with that.
Attachment #498655 - Flags: review?(mnyromyr) → review+
(Assignee)

Comment 10

6 years ago
Landed with tooltip "Create new folder":
http://hg.mozilla.org/comm-central/rev/2a2a7ccd36dc
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b2

Updated

6 years ago
Blocks: 624639
(Assignee)

Updated

6 years ago
No longer blocks: 624639
You need to log in before you can comment on or make changes to this bug.