The bookmarks panel was turned into an arrow panel in bug 590105. We need to style this panel properly on mac.
Created attachment 498522 [details] [diff] [review]
This is all styling that's needed - ported from firefox. The only thing I've changed is some code-wise styling (also note that firefox uses pre-defined stuff in shared.inc which I had to excerpt)
Created attachment 498556 [details] [diff] [review]
Fixed some indentation, added html namespace & credits
jftr, our star icons doesn't really fit here and we should have a larger icon in the panel imo.
Created attachment 498652 [details] [diff] [review]
OK, so this is ready now. This is basically a straight port from Firefox's browser.css, main differences are:
- removed a lot of unneeded important rules (the ones that are left are needed)
- slightly different structure, elements with the same rules are put together (e.g hover:active, focus etc), I omitted the navigator-specific ones, since I think it's better to have them separate from a maintenance pow.
browser.css can btw probably live without the sorting, because they have shared.inc where they put the common rules.
Oh, then I discovered that our placeholder isn't set on the tags field - it almost got me mad, because I first thought that some style rule was wrong.
The focus ring on the +-button isn't 100% right, but it looks like that in FF as well and I haven't been able to fins out what's happening.
Created attachment 498655 [details] [diff] [review]
v1.0 for real
Whoops, forgot that I had a little hack in there - this one should be the right one.
Created attachment 498656 [details]
screenshots, before and after
This is nice, could you file a bug to have this done for non-Mac as well? We're missing a similar set of rules in the normal default theme files.
(In reply to comment #7)
> This is nice, could you file a bug to have this done for non-Mac as well? We're
> missing a similar set of rules in the normal default theme files.
Filed bug 620417.
Comment on attachment 498655 [details] [diff] [review]
v1.0 for real
But the "New Folder" button should have a tooltip - I involuntarily added a new folder to my bookmarks (which I couldn't even delete in that dialog!), because the function of that [+] is totally non-obvious.
r=me with that.
Landed with tooltip "Create new folder":