620132 - [Mac Default] - Style the bookmarks arrow panel

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Stefan [:stefanh]]

The bookmarks panel was turned into an arrow panel in bug 590105. We need to style this panel properly on mac.

Comment 1

[Stefan [:stefanh]]

Attachment: WIP

This is all styling that's needed - ported from firefox. The only thing I've changed is some code-wise styling (also note that firefox uses pre-defined stuff in shared.inc which I had to excerpt)

Comment 2

[Stefan [:stefanh]]

Attachment: WIP2

Fixed some indentation, added html namespace & credits

Comment 3

[Stefan [:stefanh]]

jftr, our star icons doesn't really fit here and we should have a larger icon in the panel imo.

Comment 4

[Stefan [:stefanh]]

Attachment: v1.0

OK, so this is ready now. This is basically a straight port from Firefox's browser.css, main differences are:

- removed a lot of unneeded important rules (the ones that are left are needed)
- slightly different structure, elements with the same rules are put together (e.g hover:active, focus etc), I omitted the navigator-specific ones, since I think it's better to have them separate from a maintenance pow.

browser.css can btw probably live without the sorting, because they have shared.inc where they put the common rules.

Oh, then I discovered that our placeholder isn't set on the tags field - it almost got me mad, because I first thought that some style rule was wrong.

The focus ring on the +-button isn't 100% right, but it looks like that in FF as well and I haven't been able to fins out what's happening.

Comment 5

[Stefan [:stefanh]]

Attachment: v1.0 for real

Whoops, forgot that I had a little hack in there - this one should be the right one.

Comment 6

[Stefan [:stefanh]]

Attachment: screenshots, before and after

Comment 7

[Robert Kaiser]

This is nice, could you file a bug to have this done for non-Mac as well? We're missing a similar set of rules in the normal default theme files.

Comment 8

[Stefan [:stefanh]]

(In reply to comment #7)
> This is nice, could you file a bug to have this done for non-Mac as well? We're
> missing a similar set of rules in the normal default theme files.

Filed bug 620417.

Comment 9

[Karsten Düsterloh]

Comment on attachment 498655 [details] [diff] [review]
v1.0 for real

Nice!
But the "New Folder" button should have a tooltip - I involuntarily added a new folder to my bookmarks (which I couldn't even delete in that dialog!), because the function of that [+] is totally non-obvious.

r=me with that.

Comment 10

[Stefan [:stefanh]]

Landed with tooltip "Create new folder":
http://hg.mozilla.org/comm-central/rev/2a2a7ccd36dc