nsBidiPresUtils should participate in CC

RESOLVED FIXED in mozilla2.0b10

Status

()

defect
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: peterv, Assigned: peterv)

Tracking

({memory-leak})

Trunk
mozilla2.0b10
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(blocking2.0 final+)

Details

Attachments

(1 attachment)

It holds strong refs to nodes, and is owned by the nsPresContext which already participates.
Assignee

Comment 1

9 years ago
Posted patch v1Splinter Review
Attachment #502796 - Flags: review?(ehsan)
Assignee

Comment 2

9 years ago
Leak fix that blocks a blocker should probably block.
blocking2.0: --- → ?

Updated

9 years ago
Keywords: mlk

Comment 3

9 years ago
Comment on attachment 502796 [details] [diff] [review]
v1

Looks great!
Attachment #502796 - Flags: review?(ehsan)
Attachment #502796 - Flags: review+
Attachment #502796 - Flags: approval2.0?
This is OK. However, keeping state in nsBidiPresUtils is actually a bug. That state is local to each API call and should go away completely between calls, in which case there is no need for CC here.

Also, mContentToFrameIndex doesn't need to hold strong refs to content, as far as I can tell.

Comment 5

9 years ago
http://hg.mozilla.org/mozilla-central/rev/eab687bc329f
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b10

Comment 6

9 years ago
(In reply to comment #4)
> This is OK. However, keeping state in nsBidiPresUtils is actually a bug. That
> state is local to each API call and should go away completely between calls, in
> which case there is no need for CC here.
> 
> Also, mContentToFrameIndex doesn't need to hold strong refs to content, as far
> as I can tell.

I filed bug 624798 on this.
Thank you than you thank you!!

This patch indeed looks to be solving our leaks for both bug 567029 and bug 587503!
blocking2.0: ? → ---

Updated

9 years ago
blocking2.0: --- → ?

Updated

9 years ago
No longer blocks: 567029
You need to log in before you can comment on or make changes to this bug.