Resource protocol shouldn't use nsDependentCString to convert an nsACString to an nsCString

RESOLVED FIXED in mozilla8

Status

()

Core
IPC
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: Edgar Flores)

Tracking

Trunk
mozilla8
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=jdm], URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 years ago
This looks as if it just needs an explicit nsCString constructor.

Comment 1

6 years ago
Relevant code is in the URL field.
Whiteboard: [good first bug]

Updated

6 years ago
Whiteboard: [good first bug] → [good first bug][mentor=jdm]
(Assignee)

Comment 2

6 years ago
Created attachment 552301 [details] [diff] [review]
Changed nsDependentCString call to nsCString

Comment 3

6 years ago
Edgar, looks like you didn't qref before uploading.
(Assignee)

Comment 4

6 years ago
Created attachment 552593 [details] [diff] [review]
Changed nsDependentCString call to nsCString v2

Sorry about that
Attachment #552301 - Attachment is obsolete: true

Updated

6 years ago
Attachment #552593 - Flags: review?(benjamin)
Attachment #552593 - Flags: review?(benjamin) → review+

Comment 5

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/2c026a7ff730
Assignee: nobody → edgarf2002
Whiteboard: [good first bug][mentor=jdm] → [good first bug][mentor=jdm][inbound]
http://hg.mozilla.org/mozilla-central/rev/2c026a7ff730
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [good first bug][mentor=jdm][inbound] → [good first bug][mentor=jdm]
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.