Closed
Bug 624738
Opened 15 years ago
Closed 14 years ago
Should not be possible to create an nsDependent(C)String from an nsA(C)String
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
DUPLICATE
of bug 611503
People
(Reporter: neil, Assigned: atulagrwl)
References
Details
Attachments
(1 obsolete file)
There are a few spots throughout the code base that try to use nsDependent(C)String as if it were PromiseFlat(C)String, which it is not. They usually get lucky because the string being promised turned out to be flat, but we should just remove the bogus constructor (after fixing all the callers).
|
Assignee | |
Comment 1•14 years ago
|
||
|
|
Assignee | |
Comment 2•14 years ago
|
||
Comment on attachment 572291 [details] [diff] [review]
Patch v1
Build busted in Windows.
Attachment #572291 -
Attachment is obsolete: true
Attachment #572291 -
Flags: review?(benjamin)
|
Reporter | |
Comment 3•14 years ago
|
||
(In reply to Atul Aggarwal from comment #2)
> (From update of attachment 572291 [details] [diff] [review])
> Build busted in Windows.
I didn't think the external API had the problem anyway.
|
|
Assignee | |
Comment 4•14 years ago
|
||
Totally true. Verified now and I thought it was due to my change :P.
Neil, shouldn't we close this issue if this is not relevant any more otherwise another fool like me will waste some time working on it :)
|
|
Reporter | |
Comment 5•14 years ago
|
||
Looks like I filed this as a duplicate by mistake...
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → DUPLICATE
|
||
Updated•5 years ago
|
Component: String → XPCOM
You need to log in
before you can comment on or make changes to this bug.
Description
•