Closed
Bug 624961
Opened 15 years ago
Closed 15 years ago
GroupItems.unregister() must remove groups from _arrangesPending[]
Categories
(Firefox Graveyard :: Panorama, defect)
Firefox Graveyard
Panorama
Tracking
(blocking2.0 -)
RESOLVED
FIXED
Firefox 4.0b10
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | - |
People
(Reporter: ttaubert, Assigned: ttaubert)
Details
(Whiteboard: [qa-])
Attachments
(1 file, 1 obsolete file)
|
765 bytes,
patch
|
Details | Diff | Splinter Review |
When groupItems are unregistered via GroupItems.unregister() they are not removed from GroupItems._arrangesPending[]. This could lead to unexpected behavior when a removed/closed group gets arranged.
|
Assignee | |
Comment 1•15 years ago
|
||
Ian, do we need a test for this? If so, how could it be done?
Attachment #503133 -
Flags: review?(ian)
|
|
Assignee | |
Comment 2•15 years ago
|
||
Passed try.
|
||
Comment 3•15 years ago
|
||
Comment on attachment 503133 [details] [diff] [review]
patch v1
Looks good. I'd say this is below the test threshold.
Attachment #503133 -
Flags: review?(ian) → review+
|
|
Assignee | |
Updated•15 years ago
|
Attachment #503133 -
Flags: approval2.0?
|
||
Comment 4•15 years ago
|
||
I think this might help with bug 622872 so nominating. Correct me if I'm wrong...
blocking2.0: --- → ?
|
||
Comment 5•15 years ago
|
||
Not a strong enough reason to block; renominate if you have stronger ones. I'll look at this again when I do my approval pass later today.
blocking2.0: ? → -
|
|
||
Comment 6•15 years ago
|
||
Comment on attachment 503133 [details] [diff] [review]
patch v1
a=beltzner
Attachment #503133 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Comment 7•15 years ago
|
||
Attachment #503133 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•15 years ago
|
Keywords: checkin-needed
|
||
Comment 8•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b10
|
||
Updated•15 years ago
|
Whiteboard: [qa-]
|
||
Updated•10 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•