When groupItems are unregistered via GroupItems.unregister() they are not removed from GroupItems._arrangesPending. This could lead to unexpected behavior when a removed/closed group gets arranged.
Ian, do we need a test for this? If so, how could it be done?
Attachment #503133 - Flags: review?(ian)
Comment on attachment 503133 [details] [diff] [review] patch v1 Looks good. I'd say this is below the test threshold.
Attachment #503133 - Flags: review?(ian) → review+
Attachment #503133 - Flags: approval2.0?
I think this might help with bug 622872 so nominating. Correct me if I'm wrong...
blocking2.0: --- → ?
Not a strong enough reason to block; renominate if you have stronger ones. I'll look at this again when I do my approval pass later today.
blocking2.0: ? → -
Comment on attachment 503133 [details] [diff] [review] patch v1 a=beltzner
Attachment #503133 - Flags: approval2.0? → approval2.0+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b10
You need to log in before you can comment on or make changes to this bug.