625038 - [SeaMonkey] mochitest-plain-5: test_bug619644.html fails to load bug619644_inner.html, since it landed

Status: VERIFIED FIXED

(Toolkit :: General, defect)

Description

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showbuilds.cgi?tree=SeaMonkey&maxdate=1293934820&hours=24&legend=0&norules=1
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1293861121.1293862312.6511.gz
Linux comm-central-trunk debug test mochitests-5/5 on 2010/12/31 21:52:01
{
...
Error loading URL http://mochi.test:8888/tests/toolkit/components/prompts/test/bug619644_inner.html : 804b0002 (NS_BINDING_ABORTED)
...
5741 ERROR TEST-UNEXPECTED-FAIL | /tests/toolkit/components/prompts/test/test_bug619644.html | Test timed out.
}

Then 1+ other test fails too then
"buildbot.slave.commands.TimeoutError: command timed out: 1200 seconds without output"
:-(

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Does Seamonkey use tab-modal prompts?  If not we should just skip the test.

Comment 2

[Philip Chee]

> Does Seamonkey use tab-modal prompts?
No.
> If not we should just skip the test.
How about making the test conditional on whether the tab-modal pref is on or off?

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

(In reply to comment #2)
> > Does Seamonkey use tab-modal prompts?
> No.
> > If not we should just skip the test.
> How about making the test conditional on whether the tab-modal pref is on or
> off?

Right.

Comment 4

[Serge Gautherie (:sgautherie)]

Yeah, the test should be a todo() when the pref is off.

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Do not run tab-modal specific tests if the app does not have tab-modal dialogs [Checked in: See comment 11]

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Do Seamonkey, Thunderbird, etc have Services.jsm?  Or do I need to get this through xpcom proper?

Comment 7

[Serge Gautherie (:sgautherie)]

(In reply to comment #6)
> Do Seamonkey, Thunderbird, etc have Services.jsm?  Or do I need to get this
> through xpcom proper?

SM and TB do, and all Toolkit apps should, iiuc:
http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/content/Makefile.in#93

Comment 8

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Cool.  I'll land this change tomorrow.

Comment 9

[Serge Gautherie (:sgautherie)]

Comment on attachment 503296 [details] [diff] [review]
Do not run tab-modal specific tests if the app does not have tab-modal dialogs
[Checked in: See comment 11]

>+  return Services.prefs.getBoolPref("prompts.tab_modal.enabled");

This pref is undefined on other apps, so this code should be 

  var prefName = "prompts.tab_modal.enabled";
  return Services.prefs.getPrefType(prefName) == Services.prefs.PREF_BOOL &&
         Services.prefs.getBoolPref(prefName);

>+  todo(0, "No tab modal prompts");

Nit: I would prefer something like

  todo(false, "Test disabled as tab modal prompts are not enabled");

Comment 10

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Bah, annoying that toolkit doesn't set a default value for this pref.

Comment 11

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/996e407e9735

Comment 12

[Serge Gautherie (:sgautherie)]

V.Fixed, per bug 626294 comment 0.

*****

(In reply to comment #0)
> Then 1+ other test fails too

I filed bug 626294.

Comment 13

[Serge Gautherie (:sgautherie)]

(In reply to comment #11)
> http://hg.mozilla.org/mozilla-central/rev/996e407e9735

Nit: a 'var' is missing:
{
18   prefName = "prompts.tab_modal.enabled";
}

Comment 14

[Serge Gautherie (:sgautherie)]

(In reply to comment #13)
> Nit: a 'var' is missing:

I fixed it in bug 626294.