Closed Bug 626294 Opened 13 years ago Closed 13 years ago

[SeaMonkey] mochitest-plain-5: permanent "TEST-UNEXPECTED-FAIL | .../test_bug620145.html | got tabmodal promptbox"

Categories

(Toolkit :: General, defect)

Product:
Toolkit
Component:
General
Type:
defect
Priority:
Not set
Severity:
major

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla2.0b10

People

(Reporter: sgautherie, Assigned: sgautherie)

References

(Depends on 1 open bug, Blocks 1 open bug,
URL
)

Details

(Whiteboard: [test that aborts the suite] [perma-orange])

Attachments

(1 file)

(Av1) Fix bug 625038 nit, Fix bug 620145 case and bug 615186 case [Checked in: Comment 2]
4.09 KB, patch
smaug
: review+
Details | Diff | Splinter Review 
I initially waited for bug 625038 to be fixed.
Now, after fixing it, this failure remains:

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1295224131.1295225452.14376.gz&fulltext=1
Linux comm-central-trunk debug test mochitests-5/5 on 2011/01/16 16:28:51
{
5749 ERROR TEST-UNEXPECTED-FAIL | /tests/toolkit/components/prompts/test/test_bug620145.html | got tabmodal promptbox
TEST-UNEXPECTED-FAIL | /tests/toolkit/components/prompts/test/test_bug620145.html | application timed out after 330 seconds with no output
}

Failing code is:
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/prompts/test/prompt_common.js
{
41         if (isTabModal) {
42           var promptBox = getTabModalPromptBox(window);
43           ok(promptBox, "got tabmodal promptbox");
}

Cause is:
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/prompts/test/test_bug620145.html?force=1
{
45   isTabModal = true;
}
It looks like this value should rather be the value of the "prompts.tab_modal.enabled" preference, should it not?
Whiteboard: [perma-orange] → [test that aborts the suite] [perma-orange]
Depends on: 625056
Depends on: 615186
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED

        Attachment #504516 -
        Flags: review?(Olli.Pettay)

        Attachment #504516 -
        Flags: review?(Olli.Pettay) → review+

    
    

    
  
Comment on attachment 504516 [details] [diff] [review]
(Av1) Fix bug 625038 nit, Fix bug 620145 case and bug 615186 case
[Checked in: Comment 2]

http://hg.mozilla.org/mozilla-central/rev/dce56b3d284b

        Attachment #504516 -
        Attachment description: (Av1) Fix bug 625038 nit, Fix bug 620145 case and bug 615186 case → (Av1) Fix bug 625038 nit, Fix bug 620145 case and bug 615186 case
[Checked in: Comment 2]

    
  
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Summary: [SeaMonkey] permanent "TEST-UNEXPECTED-FAIL | .../test_bug620145.html | got tabmodal promptbox" → [SeaMonkey] mochitest-plain-5: permanent "TEST-UNEXPECTED-FAIL | .../test_bug620145.html | got tabmodal promptbox"
Target Milestone: --- → mozilla2.0b10

    
    

    
  
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1295298409.1295298747.22125.gz&fulltext=1
Rev3 Fedora 12 mozilla-central opt test mochitests-5/5 on 2011/01/17 13:06:49
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1295306576.1295307399.28405.gz&fulltext=1
OS X 10.6 comm-central-trunk debug test mochitests-5/5 on 2011/01/17 15:22:56

V.Fixed
Status: RESOLVED → VERIFIED

    
    

    
      
  

          You need to log in
          before you can comment on or make changes to this bug.