626294 - [SeaMonkey] mochitest-plain-5: permanent "TEST-UNEXPECTED-FAIL | .../test_bug620145.html | got tabmodal promptbox"

Status: VERIFIED FIXED

(Toolkit :: General, defect)

Description

[Serge Gautherie (:sgautherie)]

I initially waited for bug 625038 to be fixed.
Now, after fixing it, this failure remains:

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1295224131.1295225452.14376.gz&fulltext=1
Linux comm-central-trunk debug test mochitests-5/5 on 2011/01/16 16:28:51
{
5749 ERROR TEST-UNEXPECTED-FAIL | /tests/toolkit/components/prompts/test/test_bug620145.html | got tabmodal promptbox
TEST-UNEXPECTED-FAIL | /tests/toolkit/components/prompts/test/test_bug620145.html | application timed out after 330 seconds with no output
}

Failing code is:
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/prompts/test/prompt_common.js
{
41         if (isTabModal) {
42           var promptBox = getTabModalPromptBox(window);
43           ok(promptBox, "got tabmodal promptbox");
}

Cause is:
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/prompts/test/test_bug620145.html?force=1
{
45   isTabModal = true;
}
It looks like this value should rather be the value of the "prompts.tab_modal.enabled" preference, should it not?

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Fix bug 625038 nit, Fix bug 620145 case and bug 615186 case [Checked in: Comment 2]

Comment 2

[Serge Gautherie (:sgautherie)]

Comment on attachment 504516 [details] [diff] [review]
(Av1) Fix bug 625038 nit, Fix bug 620145 case and bug 615186 case
[Checked in: Comment 2]

http://hg.mozilla.org/mozilla-central/rev/dce56b3d284b

Comment 3

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1295298409.1295298747.22125.gz&fulltext=1
Rev3 Fedora 12 mozilla-central opt test mochitests-5/5 on 2011/01/17 13:06:49
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1295306576.1295307399.28405.gz&fulltext=1
OS X 10.6 comm-central-trunk debug test mochitests-5/5 on 2011/01/17 15:22:56

V.Fixed

Comment 4

[Legacy TBPL/Treeherder Robot]

mounir
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1302300719.1302301465.20750.gz
Rev3 Fedora 12 mozilla-central opt test mochitests-5/5 on 2011/04/08 15:11:59

s: talos-r3-fed-029
5434 ERROR TEST-UNEXPECTED-FAIL | /tests/toolkit/components/prompts/test/test_bug620145.html | got tabmodal promptbox
TEST-UNEXPECTED-FAIL | /tests/toolkit/components/prompts/test/test_bug620145.html | application timed out after 330 seconds with no output
PROCESS-CRASH | /tests/toolkit/components/prompts/test/test_bug620145.html | application crashed (minidump found)
Thread 0 (crashed)