625156 - Tab Groups menu button does not toggle Tab View when browser window is out of focus

Status: VERIFIED FIXED

(Firefox Graveyard :: Panorama, defect, P3)

Description

[Aaron Train [:aaronmt]]

Currently on

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b10pre) Gecko/20110112 Firefox/4.0b10pre

tabGroupsButton (View -> Tab Groups) is inactive when the browser window is out of focus. Clicking it will not toggle the tab view.

On Mac, this is particularly easy to reproduce, simply open the Downloads window or bring forth into the foreground the About Minefield/Firefox window.

tabGroupsButton should either be disabled or work on the appropriate window

[1] http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.xul#846

Comment 1

[Aaron Train [:aaronmt]]

Not sure if this is more appropriate under the Menu component. Please move if appropriate.

Comment 2

[Kevin Hanes]

Yup. Tab Candy is the right component. 

Punting to future.

Comment 3

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Trivial patch

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 506059 [details] [diff] [review]
Trivial patch

>diff --git a/browser/base/content/browser.js b/browser/base/content/browser.js
>--- a/browser/base/content/browser.js
>+++ b/browser/base/content/browser.js
>@@ -1731,17 +1731,18 @@ function BrowserShutdown()
> // macBrowserOverlay
> function nonBrowserWindowStartup()
> {
>   // Disable inappropriate commands / submenus
>   var disabledItems = ['Browser:SavePage',
>                        'Browser:SendLink', 'cmd_pageSetup', 'cmd_print', 'cmd_find', 'cmd_findAgain',
>                        'viewToolbarsMenu', 'viewSidebarMenuMenu', 'Browser:Reload',
>                        'viewFullZoomMenu', 'pageStyleMenu', 'charsetMenu', 'View:PageSource', 'View:FullScreen',
>-                       'viewHistorySidebar', 'Browser:AddBookmarkAs', 'View:PageInfo', 'Tasks:InspectPage'];
>+                       'viewHistorySidebar', 'Browser:AddBookmarkAs', 'View:PageInfo', 'Tasks:InspectPage',
>+                       'Browser:ToggleTabView', 'Browser:ShowTabView', 'Browser:HideTabView'];

What are Browser:ShowTabView and Browser:HideTabView used for?

Comment 5

[Michael Yoshitaka Erlewine [:mitcho]]

(In reply to comment #4)
> What are Browser:ShowTabView and Browser:HideTabView used for?

Currently, nothing is bound to these commands, but they're specified in the mainCommandSet. I believe the gestures we used to have were tied to these.

Dāo, do you suggest we remove these commands from the command set? If not, someone may map a custom key combo or gesture against these commands, and we'd want them disabled.

Comment 6

[Dão Gottwald [:dao]]

(In reply to comment #5)
> Dāo, do you suggest we remove these commands from the command set?

I think we should probably do that.

> If not,
> someone may map a custom key combo or gesture against these commands, and we'd
> want them disabled.

The gestures wouldn't be registered in non-browser windows anyway.

Comment 7

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Trivial patch, with removal of Browser:ShowTabView and Browser:HideTabView

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 506408 [details] [diff] [review]
Trivial patch, with removal of Browser:ShowTabView and Browser:HideTabView

a=beltzner

Comment 9

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Patch for checkin

Comment 10

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/43da3bf218c3

Comment 11

[Tracy Walker [:tracy]]

verified with nightly build of minefield.