Tab Groups menu button does not toggle Tab View when browser window is out of focus

VERIFIED FIXED in Firefox 4.0b11

Status

defect
P3
normal
VERIFIED FIXED
8 years ago
3 years ago

People

(Reporter: aaronmt, Assigned: mitcho)

Tracking

({ux-consistency})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [ux][polish])

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

8 years ago
Currently on

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b10pre) Gecko/20110112 Firefox/4.0b10pre

tabGroupsButton (View -> Tab Groups) is inactive when the browser window is out of focus. Clicking it will not toggle the tab view.

On Mac, this is particularly easy to reproduce, simply open the Downloads window or bring forth into the foreground the About Minefield/Firefox window.

tabGroupsButton should either be disabled or work on the appropriate window

[1] http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.xul#846
(Reporter)

Comment 1

8 years ago
Not sure if this is more appropriate under the Menu component. Please move if appropriate.
(Reporter)

Updated

8 years ago
Summary: tabGroupsButton is inactive when browser window is out of focus → Tab Groups menu button does not toggle Tab View when browser window is out of focus

Comment 2

8 years ago
Yup. Tab Candy is the right component. 

Punting to future.
Priority: -- → P3
Target Milestone: --- → Future
Posted patch Trivial patch (obsolete) — Splinter Review
Assignee: nobody → mitcho
Status: NEW → ASSIGNED
Attachment #506059 - Flags: review?(dao)
Attachment #506059 - Flags: feedback?(ian)
Keywords: ux-consistency
OS: Mac OS X → All
Hardware: x86 → All
Whiteboard: [ux][polish]
Blocks: 627096
Target Milestone: Future → ---
Comment on attachment 506059 [details] [diff] [review]
Trivial patch

>diff --git a/browser/base/content/browser.js b/browser/base/content/browser.js
>--- a/browser/base/content/browser.js
>+++ b/browser/base/content/browser.js
>@@ -1731,17 +1731,18 @@ function BrowserShutdown()
> // macBrowserOverlay
> function nonBrowserWindowStartup()
> {
>   // Disable inappropriate commands / submenus
>   var disabledItems = ['Browser:SavePage',
>                        'Browser:SendLink', 'cmd_pageSetup', 'cmd_print', 'cmd_find', 'cmd_findAgain',
>                        'viewToolbarsMenu', 'viewSidebarMenuMenu', 'Browser:Reload',
>                        'viewFullZoomMenu', 'pageStyleMenu', 'charsetMenu', 'View:PageSource', 'View:FullScreen',
>-                       'viewHistorySidebar', 'Browser:AddBookmarkAs', 'View:PageInfo', 'Tasks:InspectPage'];
>+                       'viewHistorySidebar', 'Browser:AddBookmarkAs', 'View:PageInfo', 'Tasks:InspectPage',
>+                       'Browser:ToggleTabView', 'Browser:ShowTabView', 'Browser:HideTabView'];

What are Browser:ShowTabView and Browser:HideTabView used for?
(In reply to comment #4)
> What are Browser:ShowTabView and Browser:HideTabView used for?

Currently, nothing is bound to these commands, but they're specified in the mainCommandSet. I believe the gestures we used to have were tied to these.

Dāo, do you suggest we remove these commands from the command set? If not, someone may map a custom key combo or gesture against these commands, and we'd want them disabled.
(In reply to comment #5)
> Dāo, do you suggest we remove these commands from the command set?

I think we should probably do that.

> If not,
> someone may map a custom key combo or gesture against these commands, and we'd
> want them disabled.

The gestures wouldn't be registered in non-browser windows anyway.
Attachment #506059 - Attachment is obsolete: true
Attachment #506408 - Flags: review?(dao)
Attachment #506059 - Flags: review?(dao)
Attachment #506059 - Flags: feedback?(ian)
Attachment #506408 - Flags: review?(dao) → review+
Attachment #506408 - Flags: approval2.0?
Comment on attachment 506408 [details] [diff] [review]
Trivial patch, with removal of Browser:ShowTabView and Browser:HideTabView

a=beltzner
Attachment #506408 - Flags: approval2.0? → approval2.0+
Attachment #506408 - Attachment is obsolete: true
Keywords: checkin-needed

Comment 10

8 years ago
http://hg.mozilla.org/mozilla-central/rev/43da3bf218c3
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b11
verified with nightly build of minefield.
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.