625412 - On Linux, RSS feed icon should show up even when menus_have_icons=false

Status: NEW

(Firefox :: Menus, defect)

Description

[Justin Lebar (not reading bugmail)]

It seems to me that the feed icon should appear even if menus_have_items=false.  At least, "Get bookmark addons" has an icon even when menus_have_icons=false, as do all the bookmarked pages, and certainly subscribing to an RSS feed is a more common operation than getting addons.

The "subscribe to this page" button was moved in FF4, and having an icon next to it would make it easier to find.

Anyway, I Am Not A UI Person, so I'm sure you guys know best.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

See bug 599735 comment 18. I think that's invalid.

Comment 2

[Justin Lebar (not reading bugmail)]

My point was that, even with menus_have_items=false, there are already a lot of icons in that menu.  So I guess I don't understand why, if there are already icons in the menu, this item shouldn't be highlighted by an icon of its own.

Comment 3

[Alex Faaborg [:faaborg] (Firefox UX)]

This is a tradeoff of violating the HIG rule (only provide icons for "places" that the user can go to), versus improving discoverability of the RSS icon.  Fwiw we decided to disregard the Apple HIG for OS X and are going ahead with displaying the rss icon over there (bug 625287)