625497 - Clear Adobe Flash Cookies (LSOs) when "Forget This Site" is selected

Status: RESOLVED FIXED

(Toolkit :: Data Sanitization, defect)

Description

[Mike Beltzner [:beltzner, not reading bugmail]]

Bug 508167 will implement support for the NPAPI methods that Adobe Flash will support in Adobe Flash 10.2+, allowing us to tell that application to delete their version of cookies (LSOs) as well.

When "Forget This Site" is invoked by a user we should use the new API from bug 508167 to clear Adobe Flash LSOs for that site. Yes, this will clear all LSOs even those set by other browsers; that's acceptable, IMO.

Comment 1

[[e-mail]]

Attachment: patch

This adds relevant bits to PB, and some tests. Ehsan, I'm not sure if you want to review this or delegate to Josh, who's reviewing the backend bits in bug 508167 -- it might make sense for both of you to look at it, since Josh will be familiar with how the guts works.

Comment 2

[(no longer active)]

Comment on attachment 509016 [details] [diff] [review]
patch

Looks great!

Comment 3

[[e-mail]]

Comment on attachment 509016 [details] [diff] [review]
patch

Requesting approval. This is a softblocker and wanted for 2.0.

Comment 4

[(no longer active)]

If this is a softblocker, it should be marked as such.

Comment 5

[Johnathan Nightingale [:johnath]]

Marking it as such

Comment 6

[[e-mail]]

http://hg.mozilla.org/mozilla-central/rev/2ff5b8624463