Entering another tab doesn't trigger collapse of an expanded tab group

VERIFIED FIXED in Firefox 4.0b10

Status

defect
P4
normal
VERIFIED FIXED
9 years ago
3 years ago

People

(Reporter: mitcho, Assigned: mitcho)

Tracking

({polish})

unspecified
Firefox 4.0b10
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [visual][polish][good first bug])

Attachments

(2 attachments, 1 obsolete attachment)

Posted video Video
STR:
1. Get a stacked group.
2. Set up another tab elsewhere as the active tab.
3. Click on that first group's expander so it fans out ("expands").
4. Through the keyboard shortcut, for example, zoom out of Panorama. You will go into the active tab.

Expected:
This should trigger a collapsing of that expanded tab group.

Reality:
It does not.

This is a follow up bug from bug 625443. The browser_tabview_expander test written there has a todo item for this.
Depends on: 625443
Updated spec from Ian in bug 625443:

When we expand a stacked group, make one of those tabs (probably the top tab) active at that point. Thus, if we then activate Panorama via the key shortcut, it will go into a tab in that group. This avoids the availability of situation described above.
Ian's new spec for this behavior was ridculously easy to implement, and it now passes all of the TODO items for this bug in the expander test (from bug 625443), except for one: because we zoom into a tab and come back so quickly, the group may be marked as no longer expanded, but the overlay DOM element may still exist. Removed that test.
Assignee: nobody → mitcho
Status: NEW → ASSIGNED
Attachment #504170 - Flags: review?(ian)
Pushed to try, on top of bug 625443 patch v1.1.
All but osx debug has passed, but my second osx debug push got eaten somehow by try, so pushed just osx debug again.
Passed try!
Comment on attachment 504170 [details] [diff] [review]
Trivial patch (requires 625443 patch v1.1)

Very nice
Attachment #504170 - Flags: review?(ian) → review+
Attachment #504170 - Flags: approval2.0?
Comment on attachment 504170 [details] [diff] [review]
Trivial patch (requires 625443 patch v1.1)

a=beltzner, with thanks for the test!
Attachment #504170 - Flags: approval2.0? → approval2.0+
Attachment #504170 - Attachment is obsolete: true
http://hg.mozilla.org/mozilla-central/rev/13790fc912fa
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: Future → Firefox 4.0b10
verified with minefield build of 20110217
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.