626274 - try be3e8b73e99b tried to load PGORT80.DLL in winxp opt xpcshell

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Nick Thomas [:nthomas] (UTC+12)]

Specifically, there's a dialog up which says
 WriteArgument.exe - Unable To Locate Component
 This application has failed to start because PGORT80.DLL was not found. Re-installing the application may fix this problem.
 [OK]

Rerun of bug 542504 or dbaron code issue ?

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Test log:
TEST-PASS | C:\talos-slave\test\build\xpcshell\tests\test_uriloader_exthandler\unit\test_handlerService.js | test passed

command timed out: 1200 seconds without output

and in the slave twistd.log there's the known buildbot bug:
2011-01-15 16:39:00-0800 [-] Unhandled Error
        Traceback (most recent call last):
          File "C:\mozilla-build\python25\lib\site-packages\twisted\application\app.py", line 390, in startReactor
            self.config, oldstdout, oldstderr, self.profiler, reactor)
          File "C:\mozilla-build\python25\lib\site-packages\twisted\application\app.py", line 311, in runReactorWithLogging
            reactor.run()
          File "C:\mozilla-build\python25\lib\site-packages\twisted\internet\base.py", line 1165, in run
            self.mainLoop()
          File "C:\mozilla-build\python25\lib\site-packages\twisted\internet\base.py", line 1174, in mainLoop
            self.runUntilCurrent()
        --- <exception caught here> ---
          File "C:\mozilla-build\python25\lib\site-packages\twisted\internet\base.py", line 796, in runUntilCurrent
            call.func(*call.args, **call.kw)
          File "C:\mozilla-build\python25\lib\site-packages\buildbot-0.8.0-py2.5.egg\buildbot\slave\commands\base.py", line 726, in doTimeout
            self.kill(msg)
          File "C:\mozilla-build\python25\lib\site-packages\buildbot-0.8.0-py2.5.egg\buildbot\slave\commands\base.py", line 791, in kill
            self.process.signalProcess(self.KILL)
          File "C:\mozilla-build\python25\lib\site-packages\twisted\internet\_dumbwin32proc.py", line 262, in signalProcess
            raise error.ProcessExitedAlready()
        twisted.internet.error.ProcessExitedAlready:

So there's a combination of test doing the wrong thing and the slave not handling it gracefully.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Similar problem for GoodPlugin-10.exe in mochitest-other (mochitest-browser-chrome) on winxp.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This was a push of a very small patch against 1.9.1 to try.  It's not an issue with my code; it's probably an issue with testing 1.9.1 builds with the current infrastructure.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Yeah, that's not a supported situation for try.

dustin, am I correct in remembering that a later version of buildbot for the slave handles that error ?

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

I assume you mean the error in comment #1, and I don't know how well that's been fixed up.  There have been some patches to it, but there are still several Buildbot bugs open on the topic.

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

Ok, we have bug 626486 now for the ProcessExitedAlready error now, and we can call this FIXED because I rescued all the slaves. We have a bug on file for try of 1.9.2 (bug 563822).