Add (take) link to bug edit page to allow quick assigning to the current user

RESOLVED FIXED in Bugzilla 4.2

Status

()

Bugzilla
Creating/Changing Bugs
--
enhancement
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: dkl, Assigned: dkl)

Tracking

Bugzilla 4.2
Bug Flags:
approval +

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
Created attachment 504717 [details] [diff] [review]
Patch to add (take) link to the assignee field (v1)

Add a new (take) link next to the (edit) link for the bug's assignee. This will allow the current user to quickly add their own email address to the assignee field using javascript functionality. If the user is already the assignee of the bug, the (take) like will not be displayed.

Patch attached.
Dave
Attachment #504717 - Flags: review?(mkanat)

Updated

7 years ago
Severity: normal → enhancement
OS: Mac OS X → All
Hardware: x86 → All
Assignee: create-and-change → dkl
Status: NEW → ASSIGNED

Updated

7 years ago
Target Milestone: --- → Bugzilla 4.2

Comment 1

7 years ago
Comment on attachment 504717 [details] [diff] [review]
Patch to add (take) link to the assignee field (v1)

Cool! Looks good, except that we shouldn't be doing things like "document.changeform.assigned_to". Instead this should probably have a separate function that it calls, that uses document.getElementById.
Attachment #504717 - Flags: review?(mkanat) → review-
(Assignee)

Comment 2

7 years ago
Created attachment 505101 [details] [diff] [review]
Patch to add (take) link to the assignee field (v2)

New patch with Max's suggested changes. I added a new argument to showEditableField that allows overriding and setting the input fields value.

Please review. If you think this would be better reviewed by Guy then feel free to change the requestee.

Dave
Attachment #504717 - Attachment is obsolete: true
Attachment #505101 - Flags: review?(mkanat)
Comment on attachment 505101 [details] [diff] [review]
Patch to add (take) link to the assignee field (v2)

>- * var ContainerInputArray[0]: the conainer that will be hidden usually shows the (edit) text
>+ * var ContainerInputArray[0]: the conainer that will be hidden usually shows the (edit) or (take) text

container.

Comment 4

7 years ago
Comment on attachment 505101 [details] [diff] [review]
Patch to add (take) link to the assignee field (v2)

Looks good and works well. :-)
Attachment #505101 - Flags: review?(mkanat) → review+

Updated

7 years ago
Flags: approval+
(Assignee)

Comment 5

7 years ago
Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bugzilla      /trunk/
modified js/field.js
modified template/en/default/bug/edit.html.tmpl                           Committed revision 7656.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED

Updated

6 years ago
Blocks: 734997
You need to log in before you can comment on or make changes to this bug.