Note: There are a few cases of duplicates in user autocompletion which are being worked on.

The 'take' link for the assignee field doesn't work when usemenuforusers is turned on

RESOLVED FIXED in Bugzilla 4.2

Status

()

Bugzilla
Creating/Changing Bugs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Mark Clements, Assigned: Frédéric Buclin)

Tracking

Bugzilla 4.2
Bug Flags:
approval +
approval4.2 +

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
User Agent: Mozilla/5.0 (Windows NT 5.1; rv:10.0.2) Gecko/20100101 Firefox/10.0.2
Build ID: 20120215223356

Steps to reproduce:

(show_bug.cgi) 

>  Assigned To: 	Person A (edit) (take) 

I loaded up a bug that was assigned to another user, and clicked the 'take' link beside the current assignee name (as shown above).



Actual results:

The behaviour seems to be identical to if you select 'edit'.

However, I noticed that the 'set_default_assignee' checkbox is being set to my e-mail address, so I suspect that there is a bit of JavaScript logic that contains a naming error somewhere.


Expected results:

It should have behaved like 'edit', but with the additional effect of changing the assignee to be me.

Note that I have some custom templates, but I temporarily disabled them by renaming 'custom' to 'custom-temp' so the built-in templates were used, and behaviour is still as described.
(Assignee)

Comment 1

5 years ago
(In reply to Mark Clements from comment #0)
> However, I noticed that the 'set_default_assignee' checkbox is being set to
> my e-mail address, so I suspect that there is a bit of JavaScript logic that
> contains a naming error somewhere.

A checkbox cannot contain an email address. It's just a checkbox. Your description is pretty confusing. If your email address appears in the Assignee field, then the bug is assigned to you.
Assignee: create-and-change → LpSolit
Status: UNCONFIRMED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → INVALID
(Reporter)

Comment 2

5 years ago
(In reply to Frédéric Buclin from comment #1)
> (In reply to Mark Clements from comment #0)
> > However, I noticed that the 'set_default_assignee' checkbox is being set to
> > my e-mail address, so I suspect that there is a bit of JavaScript logic that
> > contains a naming error somewhere.
> 
> A checkbox cannot contain an email address. It's just a checkbox. Your
> description is pretty confusing. If your email address appears in the
> Assignee field, then the bug is assigned to you.

Obviously.

Apologies if the description confused you.

The relevant part of the form contains two input fields:
* A select box with the id 'assigned_to'
* A checkbox with the id 'set_default_assignee'

Both are hidden on form load, and are shown when you click either 'edit' or 'take'.

In addition, 'take' is setting the checkbox to my e-mail address.

What it *should* be doing is setting the select box to my e-mail address.

Please test before resolving as invalid.
Status: RESOLVED → UNCONFIRMED
Resolution: INVALID → ---
(Assignee)

Comment 3

5 years ago
(In reply to Mark Clements from comment #2)
> The relevant part of the form contains two input fields:
> * A select box with the id 'assigned_to'

Select box? You have usemenuforusers turned on?


> In addition, 'take' is setting the checkbox to my e-mail address.

Again, a checkbox cannot contain an email address.


> Please test before resolving as invalid.

I tested, but you didn't give all the information. :)
Assignee: LpSolit → create-and-change
(Assignee)

Updated

5 years ago
Summary: 'take' link for assignee field not working → The 'take' link for the assignee field doesn't work when usemenuforusers is turned on
(Reporter)

Comment 4

5 years ago
(In reply to Frédéric Buclin from comment #3)
> (In reply to Mark Clements from comment #2)
> > The relevant part of the form contains two input fields:
> > * A select box with the id 'assigned_to'
> 
> Select box? You have usemenuforusers turned on?

Ah - yes.  I'd forgotten about that.

> > In addition, 'take' is setting the checkbox to my e-mail address.
> 
> Again, a checkbox cannot contain an email address.
> 

In theory.  In practice, yes it does.  If I examine the element in Firebug, its value is my e-mail address.  Not sure what would happen if I submitted with that value present though (whether it converts it to boolean or submits it as-is).

Of course, that could be a bug in Firebug...

> > Please test before resolving as invalid.
> 
> I tested, but you didn't give all the information. :)

In that case, I apologise.  Keep up the good work! :-)
(Assignee)

Comment 5

5 years ago
I can reproduce the issue, so confirmed.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Target Milestone: --- → Bugzilla 4.2
(Assignee)

Updated

5 years ago
Depends on: 626658
(Assignee)

Comment 6

5 years ago
Created attachment 612596 [details] [diff] [review]
patch, v1

Asking dkl as he implemented the (take) link. I had to fix showEditableField() to accept both an <input> or a <select> field.
Assignee: create-and-change → LpSolit
Status: NEW → ASSIGNED
Attachment #612596 - Flags: review?(dkl)
Comment on attachment 612596 [details] [diff] [review]
patch, v1

r=glob
Attachment #612596 - Flags: review?(dkl) → review+
(Assignee)

Updated

5 years ago
Flags: approval4.2+
Flags: approval+
(Assignee)

Comment 8

5 years ago
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified js/field.js
Committed revision 8179.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.2/
modified js/field.js
Committed revision 8065.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.