Closed Bug 626716 Opened 10 years ago Closed 9 years ago

Remove VC7.1 support code

Categories

(Core :: JavaScript Engine, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: neil, Assigned: neil)

References

Details

(Whiteboard: [fixed-in-nanojit][fixed-in-tracemonkey])

Attachments

(3 files)

Support for VC7.1 (and VC8 without service pack) was dropped in bug 610936.

Some code which was added to support VC7.1 for Firefox 3.5 can now be removed.
Attached patch Proposed patchSplinter Review
Attachment #504787 - Flags: review?(nnethercote)
Assignee: general → neil
Status: NEW → ASSIGNED
Comment on attachment 504787 [details] [diff] [review]
Proposed patch

Nanojit is shared with Adobe, so I'm asking Ed to review this as well.

Neil, the check-in procedure for Nanojit is also non-standard.  See https://developer.mozilla.org/en/NanojitMerge for details.
Attachment #504787 - Flags: review?(edwsmith)
Comment on attachment 504787 [details] [diff] [review]
Proposed patch

The TM-specific (non-nanojit) parts look fine to me.  We'll need Ed to confirm whether the nanojit changes are acceptable to Adobe.
Attachment #504787 - Flags: review?(nnethercote) → review+
On the surface, I think we still support at least one broken compiler that doesn't understand varadic macros (Symbian).  I will double check and follow up.
This is the tamarin-redux part.
Attachment #507860 - Flags: review?(rreitmai)
Attachment #504787 - Flags: review?(edwsmith) → review+
Attachment #507860 - Flags: review?(rreitmai) → review+
Keywords: checkin-needed
Pushed changeset 7f482bf4ca5a to nanojit-central.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Depends on: post2.0
Resolution: --- → FIXED
Whiteboard: [fixed in nanojit-central][needs merging to tracemonkey][needs merging to tamarin-redux]
http://hg.mozilla.org/tracemonkey/rev/7d3160757f82

Reopening, because it hasn't been merged everywhere yet.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: [fixed in nanojit-central][needs merging to tracemonkey][needs merging to tamarin-redux] → fixed-in-nanojit, fixed-in-tracemonkey
Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey → fixed-in-nanojit, fixed-in-tracemonkey, not-ready-for-cedar
http://hg.mozilla.org/mozilla-central/rev/7d3160757f82
Status: REOPENED → RESOLVED
Closed: 10 years ago9 years ago
Resolution: --- → FIXED
Reopening, because only the nanojit portions have landed.
Keywords: checkin-needed
Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey, not-ready-for-cedar → fixed-in-nanojit
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
http://hg.mozilla.org/tracemonkey/rev/b42dc3bee7a6
Whiteboard: fixed-in-nanojit → [fixed-in-nanojit][fixed-in-tracemonkey]
I believe it doesn't need to be marked as checkin-needed given that it's now in tracemonkey.
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/b42dc3bee7a6
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.