Closed
Bug 626716
Opened 14 years ago
Closed 14 years ago
Remove VC7.1 support code
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: neil, Assigned: neil)
References
Details
(Whiteboard: [fixed-in-nanojit][fixed-in-tracemonkey])
Attachments
(3 files)
|
5.29 KB,
patch
|
n.nethercote
:
review+
edwsmith
:
review+
|
Details | Diff | Splinter Review |
|
866 bytes,
patch
|
rreitmai
:
review+
|
Details | Diff | Splinter Review |
|
2.10 KB,
patch
|
Details | Diff | Splinter Review |
Support for VC7.1 (and VC8 without service pack) was dropped in bug 610936. Some code which was added to support VC7.1 for Firefox 3.5 can now be removed.
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #504787 -
Flags: review?(nnethercote)
|
|
Assignee | |
Updated•14 years ago
|
Assignee: general → neil
Status: NEW → ASSIGNED
|
||
Comment 2•14 years ago
|
||
Comment on attachment 504787 [details] [diff] [review] Proposed patch Nanojit is shared with Adobe, so I'm asking Ed to review this as well. Neil, the check-in procedure for Nanojit is also non-standard. See https://developer.mozilla.org/en/NanojitMerge for details.
Attachment #504787 -
Flags: review?(edwsmith)
|
|
||
Comment 3•14 years ago
|
||
Comment on attachment 504787 [details] [diff] [review] Proposed patch The TM-specific (non-nanojit) parts look fine to me. We'll need Ed to confirm whether the nanojit changes are acceptable to Adobe.
Attachment #504787 -
Flags: review?(nnethercote) → review+
|
||
Comment 4•14 years ago
|
||
On the surface, I think we still support at least one broken compiler that doesn't understand varadic macros (Symbian). I will double check and follow up.
|
|
||
Comment 5•14 years ago
|
||
This is the tamarin-redux part.
Attachment #507860 -
Flags: review?(rreitmai)
|
|
||
Updated•14 years ago
|
Attachment #504787 -
Flags: review?(edwsmith) → review+
|
||
Updated•14 years ago
|
Attachment #507860 -
Flags: review?(rreitmai) → review+
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 6•14 years ago
|
||
Pushed changeset 7f482bf4ca5a to nanojit-central.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Depends on: post2.0
Resolution: --- → FIXED
Whiteboard: [fixed in nanojit-central][needs merging to tracemonkey][needs merging to tamarin-redux]
|
|
||
Comment 7•14 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/7d3160757f82 Reopening, because it hasn't been merged everywhere yet.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: [fixed in nanojit-central][needs merging to tracemonkey][needs merging to tamarin-redux] → fixed-in-nanojit, fixed-in-tracemonkey
|
|
||
Updated•14 years ago
|
Keywords: checkin-needed
|
|
||
Updated•14 years ago
|
Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey → fixed-in-nanojit, fixed-in-tracemonkey, not-ready-for-cedar
|
||
Comment 8•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/7d3160757f82
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 9•14 years ago
|
||
Reopening, because only the nanojit portions have landed.
Keywords: checkin-needed
Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey, not-ready-for-cedar → fixed-in-nanojit
|
|
Assignee | |
Updated•14 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 10•14 years ago
|
||
|
||
Comment 11•14 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/b42dc3bee7a6
Whiteboard: fixed-in-nanojit → [fixed-in-nanojit][fixed-in-tracemonkey]
|
||
Comment 12•14 years ago
|
||
I believe it doesn't need to be marked as checkin-needed given that it's now in tracemonkey.
Keywords: checkin-needed
|
|
||
Comment 13•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/b42dc3bee7a6
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•