Remove VC7.1 support code

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: neil@parkwaycc.co.uk)

Tracking

Trunk
x86
Windows XP
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-nanojit][fixed-in-tracemonkey])

Attachments

(3 attachments)

(Assignee)

Description

6 years ago
Support for VC7.1 (and VC8 without service pack) was dropped in bug 610936.

Some code which was added to support VC7.1 for Firefox 3.5 can now be removed.
(Assignee)

Comment 1

6 years ago
Created attachment 504787 [details] [diff] [review]
Proposed patch
Attachment #504787 - Flags: review?(nnethercote)
(Assignee)

Updated

6 years ago
Assignee: general → neil
Status: NEW → ASSIGNED
Comment on attachment 504787 [details] [diff] [review]
Proposed patch

Nanojit is shared with Adobe, so I'm asking Ed to review this as well.

Neil, the check-in procedure for Nanojit is also non-standard.  See https://developer.mozilla.org/en/NanojitMerge for details.
Attachment #504787 - Flags: review?(edwsmith)
Comment on attachment 504787 [details] [diff] [review]
Proposed patch

The TM-specific (non-nanojit) parts look fine to me.  We'll need Ed to confirm whether the nanojit changes are acceptable to Adobe.
Attachment #504787 - Flags: review?(nnethercote) → review+

Comment 4

6 years ago
On the surface, I think we still support at least one broken compiler that doesn't understand varadic macros (Symbian).  I will double check and follow up.

Comment 5

6 years ago
Created attachment 507860 [details] [diff] [review]
Remove use of NJ_NO_VARIADIC_MACROS from Tamarin

This is the tamarin-redux part.
Attachment #507860 - Flags: review?(rreitmai)

Updated

6 years ago
Attachment #504787 - Flags: review?(edwsmith) → review+

Updated

6 years ago
Attachment #507860 - Flags: review?(rreitmai) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
(Assignee)

Comment 6

6 years ago
Pushed changeset 7f482bf4ca5a to nanojit-central.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Depends on: 610267
Resolution: --- → FIXED
Whiteboard: [fixed in nanojit-central][needs merging to tracemonkey][needs merging to tamarin-redux]
http://hg.mozilla.org/tracemonkey/rev/7d3160757f82

Reopening, because it hasn't been merged everywhere yet.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: [fixed in nanojit-central][needs merging to tracemonkey][needs merging to tamarin-redux] → fixed-in-nanojit, fixed-in-tracemonkey
Keywords: checkin-needed
Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey → fixed-in-nanojit, fixed-in-tracemonkey, not-ready-for-cedar
http://hg.mozilla.org/mozilla-central/rev/7d3160757f82
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
(Assignee)

Comment 9

6 years ago
Reopening, because only the nanojit portions have landed.
Keywords: checkin-needed
Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey, not-ready-for-cedar → fixed-in-nanojit
(Assignee)

Updated

6 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 10

6 years ago
Created attachment 525789 [details] [diff] [review]
Remainder of patch for check in
http://hg.mozilla.org/tracemonkey/rev/b42dc3bee7a6
Whiteboard: fixed-in-nanojit → [fixed-in-nanojit][fixed-in-tracemonkey]
I believe it doesn't need to be marked as checkin-needed given that it's now in tracemonkey.
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/b42dc3bee7a6
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.