626722 - Cannot delete attachment from add-on

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Add-on Builder, defect, P1)

Description

[Daniel Buchner [:dbuc]]

Try to delete the duplicate github.js from the add-on's attachment section, it is impossible. The attachment reappears on page reload.

https://builder.addons.mozilla.org/addon/1000044/latest/

Comment 1

[Piotr Zalewa [:zalun]]

The bug is that the system allowed to have duplicate attachments.
Also I think in the next UI option attachments will be identified by id.

Comment 2

[Daniel Buchner [:dbuc]]

I am reopening this until we are positive there will be no unintended duplication of attachments. From your answer, I am not sure we are on the same page. The duplicate attachment does not occur from uploading it twice or creating two of the same attachment via any user recognized action, instead it is happening autonomously without directed action to upload or create anything new.

For the reasons above I am suspect that this is simple UI confusion or two elements being labeled/ID wrong. Perhaps you can clarify what you meant if I am not framing your last comment accurately.

Comment 3

[Piotr Zalewa [:zalun]]

from the source code 

attachments: [
{"get_url": "/attachment/60", ...,  "uid": "60", "filename": "github"}, 
{"get_url": "/attachment/81", ..., "uid": "81", "filename": "github"},
{"get_url": "/attachment/84", ..., "uid": "84", "filename": "squeeze_box"}],

These are different attachments for the system
The problem is that possibly due to an error in updating version number after adding an attachment it was (is?) possible to create duplicate attachments.

One can't delete the attachment as system assumes there is no dulicate attachment and fails to find an unique attachment with the name "github" in this PackageVersion. Attachment is identified by its name and PackageVersion's version_number.

In the new UI Attachment will be identified by its id_number hence the issue will solve itself.

Comment 4

[Daniel Buchner [:dbuc]]

so you are saying that even though there is a record coming from the backend that is created in the UI, it isn't really there? I am happy to close this after we confirm that it does solve itself, I guess we'll wait to test it!

Comment 5

[Piotr Zalewa [:zalun]]

it could happen that the add-on with duplicated add-on is broken forever.
as a fix it might be possible to copy such add-on with the new code, I've deleted it

Comment 6

[Piotr Zalewa [:zalun]]

just checked - one is able to delete the duplicated attachment

Comment 7

[Ayan Shah[:ashah]]

Verified on stage:

https://builder-addons-next.allizom.org