do not open a new tab when panorama is run for the first time

VERIFIED FIXED

Status

Firefox Graveyard
Panorama
VERIFIED FIXED
7 years ago
2 years ago

People

(Reporter: beltzner, Assigned: mitcho)

Tracking

Details

(Whiteboard: [hardblocker][fx4-fixed-bugday])

Attachments

(1 attachment, 1 obsolete attachment)

The page at https://www-trunk.stage.mozilla.com/en-US/firefox/panorama/ is intended to be loaded in a new tab the first time a user runs Panorama. It's a great idea, but right now we don't have resources to:

 - update the video to the latest UI & shortcuts
 - translate the video into 72 languages

Until we get those resources, I think we should refrain from opening a new tab on panorama firstrun. We can keep all the code that lets us know if someone's run panorama before or not (that might be useful in other ways!) just drop the open tab action.
Marking this a hardblocker for now; please renominate if you think this strategy is bogus.
blocking2.0: --- → final+
Whiteboard: [hardblocker]
(Assignee)

Comment 2

7 years ago
Happy to take care of this quick. Ian, please let us know if you disagree with the strategy.
Assignee: nobody → mitcho
Status: NEW → ASSIGNED
Yes, this seems fair given where we are at. Post Firefox 4, we need to revisit the first-run experience, though, to address the common questions that we now know people have.

Also, not including this help directly in the product means it's all the more important that we have good information about Panorama available elsewhere.
(In reply to comment #3)
> Yes, this seems fair given where we are at. Post Firefox 4, we need to revisit
> the first-run experience, though, to address the common questions that we now
> know people have.
> 
> Also, not including this help directly in the product means it's all the more
> important that we have good information about Panorama available elsewhere.

Adding Grace and Faaborg, as the above affects them.
(Assignee)

Comment 5

7 years ago
(In reply to comment #3)
> Also, not including this help directly in the product means it's all the more
> important that we have good information about Panorama available elsewhere.

Including perhaps on that welcome page itself, in text.
(Assignee)

Updated

7 years ago
Blocks: 626926
(Assignee)

Comment 6

7 years ago
Created attachment 504953 [details] [diff] [review]
Trivial patch

Passed locally. Pushed to try.
Attachment #504953 - Flags: review?(ian)
(Assignee)

Updated

7 years ago
OS: Windows 7 → All
(Assignee)

Comment 7

7 years ago
Passed try.
Comment on attachment 504953 [details] [diff] [review]
Trivial patch

>       GroupItems.setActiveGroupItem(groupItem);

Seems like this should still happen?

R+ with that
Attachment #504953 - Flags: review?(ian) → review+
(Assignee)

Comment 9

7 years ago
Created attachment 505542 [details] [diff] [review]
Patch for checkin

Incorporated trivial change from last patch, which passed on try. Passes tests locally.
Attachment #504953 - Attachment is obsolete: true
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
Whiteboard: [hardblocker] → [hardblocker][needs landing]
http://hg.mozilla.org/mozilla-central/rev/2b1174e4d6aa
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
(Assignee)

Updated

7 years ago
Whiteboard: [hardblocker][needs landing] → [hardblocker]
Verified with b11 build on win XP
Status: RESOLVED → VERIFIED
Whiteboard: [hardblocker] → [hardblocker][fx4-fixed-bugday]
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.