626754 - do not open a new tab when panorama is run for the first time

Status: VERIFIED FIXED

(Firefox Graveyard :: Panorama, defect)

Description

[Mike Beltzner [:beltzner, not reading bugmail]]

The page at https://www-trunk.stage.mozilla.com/en-US/firefox/panorama/ is intended to be loaded in a new tab the first time a user runs Panorama. It's a great idea, but right now we don't have resources to:

 - update the video to the latest UI & shortcuts
 - translate the video into 72 languages

Until we get those resources, I think we should refrain from opening a new tab on panorama firstrun. We can keep all the code that lets us know if someone's run panorama before or not (that might be useful in other ways!) just drop the open tab action.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Marking this a hardblocker for now; please renominate if you think this strategy is bogus.

Comment 2

[Michael Yoshitaka Erlewine [:mitcho]]

Happy to take care of this quick. Ian, please let us know if you disagree with the strategy.

Comment 3

[Ian Gilman [:iangilman]]

Yes, this seems fair given where we are at. Post Firefox 4, we need to revisit the first-run experience, though, to address the common questions that we now know people have.

Also, not including this help directly in the product means it's all the more important that we have good information about Panorama available elsewhere.

Comment 4

[Ian Gilman [:iangilman]]

(In reply to comment #3)
> Yes, this seems fair given where we are at. Post Firefox 4, we need to revisit
> the first-run experience, though, to address the common questions that we now
> know people have.
> 
> Also, not including this help directly in the product means it's all the more
> important that we have good information about Panorama available elsewhere.

Adding Grace and Faaborg, as the above affects them.

Comment 5

[Michael Yoshitaka Erlewine [:mitcho]]

(In reply to comment #3)
> Also, not including this help directly in the product means it's all the more
> important that we have good information about Panorama available elsewhere.

Including perhaps on that welcome page itself, in text.

Comment 6

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Trivial patch

Passed locally. Pushed to try.

Comment 7

[Michael Yoshitaka Erlewine [:mitcho]]

Passed try.

Comment 8

[Ian Gilman [:iangilman]]

Comment on attachment 504953 [details] [diff] [review]
Trivial patch

>       GroupItems.setActiveGroupItem(groupItem);

Seems like this should still happen?

R+ with that

Comment 9

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Patch for checkin

Incorporated trivial change from last patch, which passed on try. Passes tests locally.

Comment 10

[Ian Gilman [:iangilman]]

http://hg.mozilla.org/mozilla-central/rev/2b1174e4d6aa

Comment 11

[Tracy Walker [:tracy]]

Verified with b11 build on win XP