626912 - Need a way to manage users

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: MozTrap, enhancement, P1)

Description

[Aakash Desai [:aakashd]]

Attachment: mock-up

The TCM will need a pane for user account management. In this pane, the following will be needed:

* A table of results entries with values shown for Username, Name, e-mail address, role and company.
* Default list of 20 results shown.
* A combobox to set the number of results per page going from 10,20,50 and 100.
When selected, the page should AJAX-ily update the listings area rather than
require a new page load.
* A checkbox per row entry when a logged in user is an admin
* Pagination that allows users to go to a certain page and to the beginning and
end of the set of results AJAX-ily.
* Edit (goes to individual account settings page) and Remove (offers a dialog to confirm whether to remove the user or not...then deletes that account if confirmed) hyperlinks

Comment 1

[Aakash Desai [:aakashd]]

Attachment: mock-up

Added comboboxes for role and a new column for state with a combobox of options available for each row entry.

Comment 2

[Aakash Desai [:aakashd]]

Attachment: mock-up revision 2

Comment 3

[Carl Meyer (:carljm)]

* We can't delete users, only deactivate them. So the Remove link has to go.
* The search box shown in the mockup isn't mentioned here in text. Is it part of this feature for .2, or being put off until a later release?
* If we're doing the search box, I'm not sure "Company" should be a searchable option. At this point I'm building the UI to be single-company for a given deployment: the company ID is set in the deployment configuration, and everything is assumed to be within the context of that company. So given that, I'd presume only users for that company would ever be shown here in the first place, which would mean there's no need to search by company. 
* I think we'll want a "filter" interface to easily say things like "I only want to see active users" or "I only want to see admins." The Django admin has a decent UX for that that we can copy. Not sure if this should be in .2 or a later release.

Comment 4

[Aakash Desai [:aakashd]]

> We can't delete users, only deactivate them. So the Remove link has to go.

Sounds good

> The search box shown in the mockup isn't mentioned here in text. Is it part
of this feature for .2, or being put off until a later release?

Yeah, it's slotted in for the .6 release and we don't need to tackle company then. That's a remnant

> I think we'll want a "filter" interface to easily say things like "I only
want to see active users" or "I only want to see admins." The Django admin has
a decent UX for that that we can copy. Not sure if this should be in .2 or a
later release.

I think it'd be a good addition to add to the .6 release alongside the search field. Do you know of any examples out in the wild of this being used?

Comment 5

[Carl Meyer (:carljm)]

(In reply to comment #4)
> > I think we'll want a "filter" interface to easily say things like "I only
> want to see active users" or "I only want to see admins." The Django admin has
> a decent UX for that that we can copy. Not sure if this should be in .2 or a
> later release.
> 
> I think it'd be a good addition to add to the .6 release alongside the search
> field. 

Ok, we can add it to .6, though I'd consider it pretty high priority to make these management lists usable (especially the potentially long ones).

> Do you know of any examples out in the wild of this being used?

Oh, we use this all the time, though I can't point directly at examples as it's generally in the private admin area of a site. As I mentioned it's built-in to the stock Django admin (which we won't be using, but we can borrow UI inspiration and perhaps even some bits of code). I'll attach a screenshot showing what it looks like, it's pretty simple.

Comment 6

[Carl Meyer (:carljm)]

Attachment: screenshot of Django admin's list-filter interface

You can see the filter interface on the right. This could also be done with dropdowns instead of links. And in that case it could be placed right below/above column headers (more like how it's done in Excel) rather than in a separate section off to the right.

Comment 7

[Aakash Desai [:aakashd]]

> Ok, we can add it to .6, though I'd consider it pretty high priority to make
these management lists usable (especially the potentially long ones).

We can move it to .4 as a number of things that were supposed to be implemented there originally are already fixed.

Comment 8

[Aakash Desai [:aakashd]]

Oh and the filters look great! They'd fill out the horizontal space of the pages a bit more than the current panel(s) with a search interface.

Comment 9

[Aakash Desai [:aakashd]]

For Carl: We won't need bulk actions on the user management pane

Comment 10

[Cameron Dawson [:camd]]

A Pivotal Tracker story has been created for this Bug: http://www.pivotaltracker.com/story/show/12857361

Comment 14

[Cameron Dawson [:camd]]

Cameron Dawson added a comment in Pivotal Tracker:   
   
The scope of this story is to support normal CRUD operations for users.  Also allow applying and revoking pre-defined user roles for them.

Comment 15

[Cameron Dawson [:camd]]

Eric Meyer changed story state to started in Pivotal Tracker

Comment 16

[Cameron Dawson [:camd]]

Cameron Dawson added a comment in Pivotal Tracker:   
   
eric: I think this one belongs to you now, right?

Comment 17

[Cameron Dawson [:camd]]

Cameron Dawson added a comment in Pivotal Tracker:   
   
eric: looks good.  Let's go with it.  :)

Comment 18

[Cameron Dawson [:camd]]

Carl Meyer added a comment in Pivotal Tracker:   
   
User management is working. Only a tiny bit of style cleanup needed: had to add a "new password" field, that label is slightly too long.

Comment 19

[Cameron Dawson [:camd]]

Carl Meyer changed story state to finished in Pivotal Tracker

Comment 20

[Cameron Dawson [:camd]]

Carl Meyer changed story state to delivered in Pivotal Tracker

Comment 21

[Cameron Dawson [:camd]]

Cameron Dawson added a comment in Pivotal Tracker:   
   
Carl: creating a new user doesn't seem to work

Comment 22

[Cameron Dawson [:camd]]

Cameron Dawson added a comment in Pivotal Tracker:   
   
I don't get any error messages when I click save.  Just doesn't show in the list.

Comment 23

[Cameron Dawson [:camd]]

Carl Meyer added a comment in Pivotal Tracker:   
   
Erm, my fault. Somehow the "roles" field got required; I was sure I had set it to not-required. And it also wasn't auto-expanding when it had an error, like it should. So there was a hidden "This field is required" error that you'd only see if you expanded "Assign roles to this user."

Both fixed now; you don't need to assign roles, and if there is an error it'll auto-expand so you see it.

Comment 24

[Cameron Dawson [:camd]]

Cameron Dawson changed story state to accepted in Pivotal Tracker