626947 - secure lock (and open lock) not centred in the partition / location bar

Status: RESOLVED INCOMPLETE

(Camino Graveyard :: Location Bar & Autocomplete, defect)

Description

[philippe (part-time)]

The images (security_broken.tiff security_lock.tiff) are offset to the right by 1px. The 'body' of the images is an odd number (11px and 15px respectively).

on IRC a couple of ideas:
1) massage the image to at least have the appearance of centred - for secure lock a little bit of drop shadow effect _may_ do the trick (but might look too busy in the small space). Not sure what, if anything, can be done about open lock.
2) crop the image to 15x16px (instead of 16x16px) - by itself this results in a blurred image (*)
3) fix it in code. Smokey pointed to:
http://mxr.mozilla.org/camino/source/camino/src/browser/LocationBarPartitionView.mm#209
… or a combination of 2 and 3


(*) http://dev.l-c-n.com/camino/lock15x16.png

Comment 1

[philippe (part-time)]

Attachment: cropped images

The 2 images cropped to 15x16px that can be used for suggestion 2+3 above.

Comment 2

[philippe (part-time)]

Attachment: current display

Comment 3

[Stuart Morgan]

Do we want centering when alone, or do we want consistent left and right visual margins around all the icons (lock and feed reader). If we only do the former, then the pair won't be centered when both show. If we do the later, the overall width will be different for closed vs open lock.

I'd prefer the latter; flipping between the two locks doesn't seem like a common case. To do that, we'd need the lock images cropped down to have consistent margins.

Comment 4

[philippe (part-time)]

(In reply to comment #3)
 
> I'd prefer the latter; flipping between the two locks doesn't seem like a
> common case. To do that, we'd need the lock images cropped down to have
> consistent margins.

the security_broken.tiff image in attachment 504992 [details] has exactly 0 margin, where as security_lock.tiff has 2px margin on left and right side. What you'd want is for security_lock.tiff to 0px margin as well (for a file size of 11x16px), am I right ?

Comment 5

[philippe (part-time)]

(In reply to comment #3)

... or did you mean to have some margins other than 0 inside the image file (and both images the same amount) - I can prepare the two images to have 1px or 2px on each side (security_lock.tiff in attachment 504992 [details] has 2px).

Comment 6

[Stuart Morgan]

0 on both would be fine

Comment 7

[philippe (part-time)]

Attachment: cropped images, version 2

(per comment 6)

Comment 8

[philippe (part-time)]

Attachment: sliced and shaved images v3

With updated security_broken.tiff from bug 669540 but sliced to size as needed in this bug.

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Committer note: don't forget to http://wiki.caminobrowser.org/Development:Committing#Checking_in_patches_from_others on the images; you can commit them, then commit the code changes, and finally push both at once, if desired ;)

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Whoops, I guess we didn't clear the 2.1? list…

Comment 11

[Mehmet]

Attachment: sliced icon vs my centered icon

Hi Phillipe,

the sliced and shaved lock icon has a negative side-effect: it's streched and (i think to 16x16 px) and looks blurred in the bar.

I've created an own centered lock icon, which looks much sharper in the bar.

Please compare them in the attached screenshot.

Regards
Mehmet

Comment 12

[Mehmet]

Attachment: lock_icon_sharp

Please try it with the attached lock icon :-)

Comment 13

[philippe (part-time)]

(In reply to Mehmet Sahin from comment #11)

> the sliced and shaved lock icon has a negative side-effect: it's streched
> and (i think to 16x16 px) and looks blurred in the bar.

Mehmet, that is expected. The (current) code that positions and sizes the icons expects larger images. The fix for this bug implies code changes, the attached icons are made for that. With a current Camino build, you should not use the attached images.

Comment 14

[Mehmet]

Okay, thanks for the clarification.