Closed Bug 626949 Opened 9 years ago Closed 9 years ago

Sync UI: Style generic change dialogs like the setup and Add a Device wizards

Categories

(Firefox :: Sync, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Tracking Status
blocking2.0 --- betaN+

People

(Reporter: philikon, Assigned: philikon)

References

Details

(Whiteboard: [softblocker][has patch][has review][fx4-fixed-bugday])

Attachments

(3 files)

+++ This bug was initially created as a clone of Bug #619013 +++

Splitting this off of bug 619013 so we can land the styling changes separate from the string changes.
Attached patch v1Splinter Review
Convert the generic change dialog to a single-page wizard and style it like the other two wizards we have already. Like with the other wizards, theming is not perfect yet (missing glyphs, etc.) but this gets us most of the way.

cf faaborg's mockups in attachment 500413 [details]
Attachment #505313 - Flags: review?(mconnor)
Attached image win7 screenshots of v1
Screenshots of the new change and update dialogs. The groupbox could use a little padding. Submitting this now because a) it's the end of the day ;) and b) would like to get some more UI feedback before I dive into the CSS.

Note that there are some small differences between this Update Sync Key dialog and faaborg's mockups:

* Due to the Windows conventions for wizard buttons, the Cancel dialog is the rightmost button.

* We display a title at the top. This is useful to further distinguish these different dialogs and it also fills a lot of big white space ;)
Attachment #505315 - Flags: feedback?(faaborg)
Whiteboard: [softblocker][has wip] → [softblocker][has patch][needs review mconnor][needs feedback faaborg]
Attached image os x screenshots of v1
Attachment #505465 - Flags: feedback?(faaborg)
Sorry about the delay, I'm going to try to get to this review tomorrow.
About the OS X screenshot: The alignments seem to be a little off compared to the Windows version. This is especially noticeable when comparing the position of the forms (sync key, etc.) to the text areas below and above.
Comment on attachment 505315 [details]
win7 screenshots of v1

This is better than what we currently have, let's get this landed and deal with minor adjustments (padding, icons, etc) in follow up bugs that don't block.
Attachment #505315 - Flags: feedback?(faaborg) → feedback+
Attachment #505465 - Flags: feedback?(faaborg) → feedback+
Whiteboard: [softblocker][has patch][needs review mconnor][needs feedback faaborg] → [softblocker][has patch][needs review mconnor]
Attachment #505313 - Flags: review?(mconnor) → review+
Whiteboard: [softblocker][has patch][needs review mconnor] → [softblocker][has patch][has review]
http://hg.mozilla.org/mozilla-central/rev/99de13ffb4fe
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
(In reply to comment #6)
> This is better than what we currently have, let's get this landed and deal with
> minor adjustments (padding, icons, etc) in follow up bugs that don't block.

Agreed. Since these issues aren't particular to just these dialogs, I've morphed bug 591122 into fixing the theming of all Sync wizards.
(In reply to comment #5)
> About the OS X screenshot: The alignments seem to be a little off compared to
> the Windows version. This is especially noticeable when comparing the position
> of the forms (sync key, etc.) to the text areas below and above.

They elements are top-aligned in all dialogs. The margins for the wizard header might just be different on OSX than on Windows. Anyway, this is fine-tuning work (bug 591122).
Verified fixed in Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b12pre) Gecko/20110204 Firefox/4.0b12pre
Status: RESOLVED → VERIFIED
Whiteboard: [softblocker][has patch][has review] → [softblocker][has patch][has review][fx4-fixed-bugday]
Blocks: 684537
No longer blocks: 615950
Comment on attachment 505313 [details] [diff] [review]
v1

>-    <image id="syncIcon"/>
The CSS for this icon was never removed.
Component: Firefox Sync: UI → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.