626962 - Implement empty transactions for GL

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

See bug 621601. We just need the GL version of that (plus some testing).

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Blocks a blocking performance regression.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

The patch is pretty trivial...

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I'm about to head off for a bit ... Matthew, could you try a GL system (either Mac or Linux should be fine) and see if this patch a) works and b) improves CPU usage for video playback a la bug 602080?

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 505223 [details] [diff] [review]
fix

Passes on try.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/mozilla-central/rev/17539a7e4275

Comment 6

[Johnathan Nightingale [:johnath]]

<johnath> roc: tn thinks you made my tab switching really really slow (empty GL transactions - sort of looks like my browser/content isn't invalidating properly)
<roc> johnath: oh dear, did I/
<roc> ?
<roc> Mac I assume?
<johnath> quite so - 10.6
<gavin> well dria filed bug 629166
<gavin> but I guess that is different
<johnath> gavin: may be, I guess we have to assume as much in the meantime, anyhow
<roc> probably should back out bug 626962 to fix that
<cjones> that's also one suspect for the reftest failures
<johnath> commenting in the bug

Looks like this should be backed out, but I'll let roc handle the heavy lifting

Comment 7

[(no longer active)]

Backed out:

http://hg.mozilla.org/mozilla-central/rev/72dfc2983fae

Comment 8

[Johnathan Nightingale [:johnath]]

Incidentally, backing this out also fixed bug 629166, so any relandings should take into consideration the effect on painting persona transitions as well.

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Still green on try --- with accelerated layers enabled this time :-). Need to build on my laptop and test manually.

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: Don't do empty transactions when painting to a non-retaining layer manager

The regression was because we were painting to the Mac's special titlebar BasicLayerManager and then clearing the NS_FRAME_UPDATE_LAYER_TREE flag. Then we'd paint the main window with the GL layer manager, but NS_FRAME_UPDATE_LAYER_TREE is not set so we we'd do an empty transaction and not update the real layer tree.

Comment 11

[Timothy Nikkel (:tnikkel)]

Comment on attachment 509074 [details] [diff] [review]
Don't do empty transactions when painting to a non-retaining layer manager

Hope we don't get any more layer manager's on a single widget in the future...

Comment 12

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/mozilla-central/rev/b4e9a17e7fe2
http://hg.mozilla.org/mozilla-central/rev/2a13f323dfa0