The default bug view has changed. See this FAQ.

SeaMonkey Windows builds have been burning since switching to omnijar

VERIFIED FIXED in seamonkey2.1b2

Status

SeaMonkey
Build Config
--
blocker
VERIFIED FIXED
6 years ago
5 years ago

People

(Reporter: Philip Chee, Assigned: sgautherie)

Tracking

Trunk
seamonkey2.1b2
x86
Windows Server 2003
Bug Flags:
in-testsuite -

SeaMonkey Tracking Flags

(seamonkey2.1 verified)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Windows builds are burning:

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1295417854.1295428553.19418.gz
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1295417664.1295424646.518.gz

make[6]: Leaving directory
`/e/builds/slave/comm-cen-trunk-w32/build/objdir/suite/app'
make[5]: Leaving directory
`/e/builds/slave/comm-cen-trunk-w32/build/objdir/suite/app'
make[4]: Leaving directory
`/e/builds/slave/comm-cen-trunk-w32/build/objdir/suite'
make[3]: Leaving directory `/e/builds/slave/comm-cen-trunk-w32/build/objdir'
make[2]: Leaving directory `/e/builds/slave/comm-cen-trunk-w32/build/objdir'
rm: cannot remove directory
`/e/builds/slave/comm-cen-trunk-w32/build/objdir/suite/app/../../mozilla/dist/bin/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}': Permission denied

Comment 1

6 years ago
Interestingly that's $(CLASSIC_EXTENSION_DIR)
(Assignee)

Comment 2

6 years ago
Created attachment 505034 [details] [diff] [review]
(Av1) Don't try to remove the current directory
[Checked in: Comment 6]

This should hopefully fix this failure.
I hope there is no need to go back to a specific directory...
Attachment #505034 - Flags: review?(kairo)

Comment 3

6 years ago
(In reply to comment #2)
> Created attachment 505034 [details] [diff] [review]
> (Av1) Don't try to remove the current directory
> 
> This should hopefully fix this failure.
> I hope there is no need to go back to a specific directory...

I experienced the same failure when building Seamonkey on OS/2 .
By coincidence(just had a midair collision when sending my comment)I changed locally my Makefile as you did with your patch  - and it built with OS/2 again, thus your solution probably works on windows as well.

Alternatively one could zip up the files from the directory above
cd $(ABS_DIST)/extensions/; $(ZIP) -r9mX $(dir).xpi $(dir)/*; \
rm -rf $(ABS_DIST)/extensions/$(dir); \
(not tested yet - it might need some escapes that the structure of the zip file doesn't include the $(dir) folder)

Updated

6 years ago
Attachment #505034 - Flags: review?(kairo) → review+
(Assignee)

Comment 4

6 years ago
(In reply to comment #3)

> locally my Makefile as you did with your patch  - and it built with OS/2 again,

That's good news.
(You could 'feedback+' my patch ;-))

> Alternatively one could zip up the files from the directory above

Yeah, I thought about that too and it would sure have my preference ...

> (not tested yet - it might need some escapes that the structure of the zip file
> doesn't include the $(dir) folder)

... but I was loath to check/test it :-|

Comment 5

6 years ago
(In reply to comment #3)
> Alternatively one could zip up the files from the directory above
> cd $(ABS_DIST)/extensions/; $(ZIP) -r9mX $(dir).xpi $(dir)/*; \

That doesn't work, as the zip ends up with a wrong structure. But deleting the current directory calls for problems, so the solution in the patch is correct.

Thanks for catching it, with the clobbering not working (bug 626164), I was pretty unsure what are real errors after the omnijar landing and which ones aren't.
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
(Assignee)

Comment 6

6 years ago
Comment on attachment 505034 [details] [diff] [review]
(Av1) Don't try to remove the current directory
[Checked in: Comment 6]

http://hg.mozilla.org/comm-central/rev/e9f62190bdf0
Attachment #505034 - Attachment description: (Av1) Don't try to remove the current directory → (Av1) Don't try to remove the current directory [Checked in: Comment 6]
(Assignee)

Updated

6 years ago
Severity: normal → blocker
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
OS: Windows 7 → Windows Server 2003
Hardware: x86_64 → x86
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b2
(Assignee)

Comment 7

6 years ago
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1295446799.1295460055.16805.gz
WINNT 5.2 comm-central-trunk build on 2011/01/19 06:19:59

V.Fixed
Status: RESOLVED → VERIFIED
(Assignee)

Updated

5 years ago
status-seamonkey2.1: wanted → verified
You need to log in before you can comment on or make changes to this bug.