626996 - WebGL tests shouldn't be loading pages from the Internet

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[[e-mail] (:bhearsum)]

I noticed that there's two WebGL tests:
http://mxr.mozilla.org/mozilla-central/source/content/canvas/test/webgl/conformance/origin-clean-conformance.html?force=1#130
http://mxr.mozilla.org/mozilla-central/source/content/canvas/test/webgl/more/functions/readPixelsBadArgs.html?force=1#116

which load images from opengl.org. For stability and repeatability reasons, they should be loaded via file:// or from a local webserver.

Comment 1

[Benoit Jacob [:bjacob] (mostly away)]

Indeed.

Need to fix that upstream so syncing stays easy. (upstream = khronos.org)

Comment 2

[(no longer active)]

I think we should address this as soon as possible in mozilla-central, and then try to upstream our patches, not the other way around.

Remember that things like this can cause the tree to be closed for a long time, and that's a risk which we just can't take right now.

Benoit, if you don't agree with fixing the tests soon, we should disable them right now before they cause us grief.

Comment 3

[Benoit Jacob [:bjacob] (mostly away)]

OK, I do this ASAP.

Comment 4

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: use local file

Thanks Ehsan for the explanation :)
This needs to be from a different domain, so this patch uses example.com

Comment 6

[(no longer active)]

Serge.  [orange] and blocking randomorange are used for specific reasons.  Please don't use them on bugs which are not intermittent oranges which have happened at least once on mozilla-central.

Comment 7

[(no longer active)]

Comment on attachment 505195 [details] [diff] [review]
use local file

r=me.  Please land on mozilla-central as soon as possible, with a=NPOTB.

Comment 8

[Jeff Muizelaar [:jrmuizel]]

(In reply to comment #7)
> Comment on attachment 505195 [details] [diff] [review]
> use local file
> 
> r=me.  Please land on mozilla-central as soon as possible, with a=NPOTB.

It seems to me like this is part of the build.

Comment 9

[Serge Gautherie (:sgautherie)]

(In reply to comment #8)
> > r=me.  Please land on mozilla-central as soon as possible, with a=NPOTB.
> 
> It seems to me like this is part of the build.

Obviously, s/NPOTB/test-only/ ;->

Comment 10

[(no longer active)]

As far as I know, NPOTB means changes which do not affect the optimized builds we send to the users.

http://hg.mozilla.org/mozilla-central/rev/3b7e6d130e8e

Comment 11

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

NPOTB is generally taken to mean "couldn't possibly affect tinderbox"

Comment 12

[Serge Gautherie (:sgautherie)]

(In reply to comment #6)
> Serge.  [orange] and blocking randomorange are used for specific reasons. 
> Please don't use them on bugs which are not intermittent oranges which have
> happened at least once on mozilla-central.

I had moved these here because of comment 5...