"Text" cursor instead of "Move" in the top of tab group

VERIFIED FIXED in Firefox 4.0b12

Status

Firefox Graveyard
Panorama
P4
normal
VERIFIED FIXED
6 years ago
a year ago

People

(Reporter: gadjo, Assigned: hobophobe)

Tracking

Trunk
Firefox 4.0b12

Details

(Whiteboard: [visual][polish][good first bug])

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

6 years ago
User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b10pre) Gecko/20110119 Firefox/4.0b10pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b10pre) Gecko/20110119 Firefox/4.0b10pre

Mouse cursor shouldn't be in "text" mode in the top part of tab group

Reproducible: Always

Steps to Reproduce:
1. Open panorama
2. Move mouse cursor to the level of "Name this group" (or how it is called in english version) input, but on the right side
Actual Results:  
Mouse cursor is "text"

Expected Results:  
Mouse cursor should be "move"
(Reporter)

Updated

6 years ago
Version: unspecified → Trunk
(Reporter)

Comment 1

6 years ago
Created attachment 505214 [details]
screenshot (mouse cursor marked in red circle)
Good call, but we'll punt this to the future unless someone gives us a patch to consider.
OS: Windows 7 → All
Hardware: x86 → All
Whiteboard: [visual][polish][good first bug]
Target Milestone: --- → Future

Updated

6 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P4
(Assignee)

Comment 3

6 years ago
Created attachment 510382 [details] [diff] [review]
Patches the tabview.css files to correctly apply the cursor:text style.
(Reporter)

Comment 4

6 years ago
So, can we put this simple looking patch in b12?
Blocks: 627096
Comment on attachment 510382 [details] [diff] [review]
Patches the tabview.css files to correctly apply the cursor:text style.

Thanks for the patch! Please move the cursor attribute into the existing .title-shield, rather than having two entries for the same class. Once that's done, please flag me for review again and it should be good to go!
Attachment #510382 - Flags: review-
Target Milestone: Future → ---
(Assignee)

Comment 6

6 years ago
Created attachment 512543 [details] [diff] [review]
Moves the cursor style to the existing selector.

Thanks for the feedback.
Attachment #510382 - Attachment is obsolete: true
Attachment #512543 - Flags: review?(ian)
Comment on attachment 512543 [details] [diff] [review]
Moves the cursor style to the existing selector.

Beautiful, thanks!
Attachment #512543 - Flags: review?(ian)
Attachment #512543 - Flags: review+
Attachment #512543 - Flags: approval2.0?
Comment on attachment 512543 [details] [diff] [review]
Moves the cursor style to the existing selector.

a=beltzner
Attachment #512543 - Flags: approval2.0? → approval2.0+
Created attachment 512914 [details] [diff] [review]
patch for checkin
Attachment #512543 - Attachment is obsolete: true
Keywords: checkin-needed
Assignee: nobody → unusualtears
Status: NEW → ASSIGNED
http://hg.mozilla.org/mozilla-central/rev/58123a02d149
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b12
verified with minefield build of 20110217
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.