627236 - can't reopen/undismiss doorhanger with a null anchor ID

Status: NEW

(Toolkit :: PopupNotifications and Notification Bars, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

Support for this was introduced in bug 617553. BEcause of the way we try to find notifications to display on iconbox clicks, we end up just hiding the anchor icon when you click on it, rather than redisplaying the notification.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

This fixes it, not sure if I like having to use getElementById().

Comment 3

[Ronny Perinke]

This should definitively be fixed for Firefox 6!

A much more easier way would be to explicitly use "#default-notification-icon" as anchor if anchorID is null, because this icon is displayed in such case.

Comment 4

[Ronny Perinke]

Attachment: use default-notification-icon if anchorID is null

uses default-notification-icon if anchorID is null AND makes the default-notification-icon "usable" (show it if used)

Comment 5

[Ronny Perinke]

Attachment: use default-notification-icon as fallback

more thorough version of my previous patch ... always use default-notification-icon as fallback

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 544861 [details] [diff] [review]
use default-notification-icon as fallback

Thanks for looking into this, but unfortunately this isn't a suitable solution, because "default-notification-icon" only exists in Firefox - this module lives in toolkit and is used by other apps.

My previous patch in this bug is what we want, I think.

Comment 7

[Matthew N. [:MattN]]

Bulk move to Toolkit::Notifications and Alerts

Filter on notifications-and-alerts-component.