627304 - add-on validation claims a javascript syntax error when there isn't one

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P3)

Description

[Anthony Shipman]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-GB; rv:1.9.2) Gecko/20100115 Firefox/3.6
Build Identifier: 

This warning has been present for every version of the add-on. The add-on runs fine.

Reproducible: Always

Steps to Reproduce:
1.validate the add-on
2.
3.
Actual Results:  
JavaScript Syntax Error

Warning: A syntax error in the JavaScript halted validation of that file.

Warning: Message: missing ; before statement
chrome/blacken.jar/chrome/content/blacken.js

1
2
3 r gBlacken = {

Expected Results:  
Line 3 actually has "var gBlacken = {"
Perhaps the garbled report is part of the problem.

Comment 1

[Wil Clouser [:clouserw]]

Attachment: blacken-1.4.3-fx.xpi

Comment 2

[Matt Basta [:basta]]

Fixed:

https://github.com/mattbasta/amo-validator/commit/89832f6c9d04fd1e9513b67e0c4405844574848a

The problem was related: while attempting to remove BOMs (which can break cssutils), too many characters were being stripped. This is fixed now using the new textfilter module that I built for the JS tests.

Comment 3

[krupa raj[:krupa]]

No JS errors on uploading the attached test file. Marking this as verified @ https://addons.allizom.org/en-US/developers/upload/1dea078604284dcebe5294f18137563d