Closed Bug 6276 Opened 26 years ago Closed 25 years ago

(feature) Rewrap some or all of a mail message

Categories

(Core :: DOM: Editor, defect, P1)

Product:
Core
Component:
DOM: Editor
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: sujay, Assigned: akkzilla)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [nsbeta2-]Composer feature work)

using 5/11 build of apprunner. The following functionality needs to be implemented for editor stream in HTML wrapping support message quoting support
Assignee: kostello → sfraser
Target Milestone: M7
Assigning to Simon, setting milestone to M7
Status: NEW → ASSIGNED
Summary: (feature) Mail/News support needs to be implemented → (feature) Mail/News quoting and wrapping support needed
We decided that streaming in HTML was not a requirement. I fixed the summary to include the two remaining requirements.
Target Milestone: M7 → M8
move to M8 per 6/15/99 meeting
Target Milestone: M8 → M9
Sorry, I'm not going to be able to get this in for M9. Could one of you mailnews guys specify more precisely what you are expecting here?
Blocks: 10770
Echoing Simon's question -- we've had InsertAsQuotation and PasteAsQuotation methods for quite a while now. What is this bug about?
jfd - can you comment?
Rich, could you explain it?
Actually, I think the only one that is still on the table is wrapping. I have to experiment with the InsertAsQuotation() calls. - rhp
Summary: (feature) Mail/News quoting and wrapping support needed → (feature) Mail/News wrapping support needed
Target Milestone: M9 → M11
I'm pushing wrapping to M11.
We have had wrapping support in the editor for quite some time (not spiffy stuff like rewrapping of quoted text, but basic wrapping of plaintext documents like 4.x did).
akkana & simon: how much of this feature is already implemented? can this bug be closed out? is there some specific piece of functionality that is still missing, that we could write a separate bug on?
My vote would be to close out this bug, and open a new RFE asking for rewrapping of quoted text (and other bugs for any other problems or feature needs that are noticed in wrapping or quoting). This blanket bug isn't doing anyone any good, and the basic functionality should all be there (has been for quite some time).
There is remaining functionality to be implemented, which is support for a 'Rewrap' menu item which rewraps badly flowed text, including quoted text. I have an initial implementation of this done, but it still needs some work. Nothing is checked in yet. This feature could easily be post-beta.
Target Milestone: M11 → M15
Post beta.
Moving out.
Target Milestone: M15 → M18
Ben is considering changing the representation of plaintext quotations to be a <pre> inside <blockquote>: see bug 31906. If this happens, then rewrapping becomes much easier: we have the option of simply removing the <pre> to change the quotation to an automatically-rewrapped html quotation. Simon, do you want to keep this bug? I've been doing the other wrapping support and would be glad to take over this bug, but if you have specific plans you want to implement, I don't want to get in the way of that.
Depends on: 31906
Summary: (feature) Mail/News wrapping support needed → (feature) Rewrap some or all of a mail message
Go ahead and take the bug for now.
Assignee: sfraser → akkana
Status: ASSIGNED → NEW
Status: NEW → ASSIGNED
Whatever the default will be, I'll still keep this bug in mind. If the pref is "use "> " instead of blockquote", I'll propably just use a <span class=txt_quote> or so instead of a blockquote and wrap the plain text quote tags with <span class=txt_citetags> or so. (I'm doing the latter anyway for display). So, you'd have to 1. remove <pre>s in the quote 2. replace <span class=txt_quote> with <blockquote type=cite> 3. remove <span class=txt_citetags>...</span> and you're set, regardless of what the user chose.
*** Bug 34549 has been marked as a duplicate of this bug. ***
This is GNKSA SHOULD #14d.
Blocks: gnksa
URL: http://www.xs4all.nl/%7Ejs/gnksa/
Severity: normal → enhancement
Summary: (feature) Rewrap some or all of a mail message → Rewrap some or all of a mail message
Summary: Rewrap some or all of a mail message → (feature) Rewrap some or all of a mail message
The rewrapping code will probably have to be smart and deal with all the styles of rewrapping we support (and, reading the comments in other bugs, it looks like there are a lot of different options). I'm dragging my feet on this one a bit to wait and see what happens with quoting of format=flowed messages before diving into this one. (Though I don't think it will be hard to get basic rewrapping going, so I might cobble up something some time when I feel energetic.)
I want to get at least a simple version of this implemented in M16.
Target Milestone: M18 → M16
updating keyword and status whiteboard to reflect that this is a beta 2 feature work bug that the Composer team deems a must fix for beta 2.
Keywords: beta2
Whiteboard: Composer feature work
Severity: enhancement → major
Priority: P3 → P1
What are these features? > stream in HTML > message quoting support
This bug, as it currently stands, is just what the Summary says. It has nothing to do with streaming in or quoting messages (which are already in as much as they're gonna be for this version, and if not, someone should open a new bug).
Keywords: nsbeta2
I have checked in at least the beginnings of wrapping code (which does take into account quotations) and a scriptable nsEditorShell API for it. It's currently in the debug menu for the editor overlay; all that needs to be done is call the item from the appropriate place in the compose window menus. I'll leave it up to J-F to put it in the right place (reassigning). Further bugs on specifics of how it works should be filed against me, as new bugs. I'm sure there will be things that can be improved. I mostly tested plaintext compose, as that's where I expect most people to want this functionality.
Assignee: akkana → ducarroz
Status: ASSIGNED → NEW
Keywords: beta2
accepting
Status: NEW → ASSIGNED
Putting on [nsbeta2-] radar. Not critical to beta2.
Whiteboard: Composer feature work → [nsbeta2-]Composer feature work
Akk, can you point me to the code, so I can adjust it for bug 31906? Also note, that mozTXTToHTMLConv provides a quote recognition, which propably should be used for this bug for consistency (making sure, exactly the same qutes are recognized) and less redundancy.
Taking this back ... I'll put this in.
Assignee: ducarroz → akkana
Status: ASSIGNED → NEW
Ben: the code eventually calls nsEditorShell::Rewrap. Yes, we should all use the same quote recognition code, and also the same quote generation code (e.g. maybe the nsICiter interface needs to be made more general or moved somewhere else so that it can work with your "recognize and colorize nested quotes" code).
Status: NEW → ASSIGNED
I've checked in the menu item. There will likely be some bugs on the implementation, e.g. the detection of quote levels; anyone who notices any, please file them as separate, specific bugs.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Thanks Akkana
verified in 5/16 build
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.